Search Unity

  1. Welcome to the Unity Forums! Please take the time to read our Code of Conduct to familiarize yourself with the forum rules and how to post constructively.
  2. We have updated the language to the Editor Terms based on feedback from our employees and community. Learn more.
    Dismiss Notice
  3. Join us on November 16th, 2023, between 1 pm and 9 pm CET for Ask the Experts Online on Discord and on Unity Discussions.
    Dismiss Notice

Question Coding Begginer need help including- input.getbutton("Fire1") And UI Button

Discussion in 'Scripting' started by shauryavarshney272, May 24, 2022.

  1. shauryavarshney272

    shauryavarshney272

    Joined:
    Nov 8, 2021
    Posts:
    8
    I am a newbie with no coding experience just started using unity I was following brackeys Ray cast shooting video,
    , and I created the gun script but I wanted to turn it into mobile so I wanted to autofire by holding a UI button.
    plz, I need help me know no code.
    this is my code.
    I was thinking is there a way to put something in place of input.getbutton to make a button that will autofire on holding.
    Thanks&sorry if this is a silly question


    Code (CSharp):
    1. using System.Collections;
    2. using System.Collections.Generic;
    3. using UnityEngine;
    4. using Unity.VisualScripting;
    5. public class Gun : MonoBehaviour
    6. {
    7.     public float damage = 10f;
    8.     public float range = 100f;
    9.     public float fireRate = 15f;
    10.     public float impactForce = 30f;
    11.  
    12.     public Camera fpsCam;
    13.     public ParticleSystem muzzleFlash;
    14.     public GameObject impactEffect;
    15.     private float nextTimeToFire = 0f;
    16.     // Update is called once per frame
    17.     public void Update()
    18.     {
    19.         if (Input.GetButton("Fire1") && Time.time >= nextTimeToFire)
    20.         {
    21.             nextTimeToFire = Time.time + 1f / fireRate;
    22.             Shoot();
    23.         }
    24.     }
    25.     public void Shoot()
    26.     {
    27.         muzzleFlash.Play();
    28.         RaycastHit hit;
    29.         if (Physics.Raycast(fpsCam.transform.position, fpsCam.transform.forward, out hit, range))
    30.         {
    31.          
    32.             Enemy enemy = hit.transform.GetComponent<Enemy>();
    33.             if (enemy != null)
    34.             {
    35.                 enemy.TakeDamage(damage);
    36.             }
    37.             if (hit.rigidbody != null)
    38.             {
    39.                 hit.rigidbody.AddForce(-hit.normal * impactForce);
    40.             }
    41.             GameObject impactGO = Instantiate(impactEffect, hit.point, Quaternion.LookRotation(hit.normal));
    42.             Destroy(impactGO, 2f);  
    43.         }
    44.     }
    45. }
    46.  

     
  2. shauryavarshney272

    shauryavarshney272

    Joined:
    Nov 8, 2021
    Posts:
    8
    umm is there anyone for reply? :(
     
  3. shauryavarshney272

    shauryavarshney272

    Joined:
    Nov 8, 2021
    Posts:
    8
    I just want to touch and hold the UI button and call the update method for auto-firing plz help ASAP.
     
  4. Kurt-Dekker

    Kurt-Dekker

    Joined:
    Mar 16, 2013
    Posts:
    36,946
    Oh dear, it sounds like maybe you didn't do the tutorial correctly.

    Specifically it sounds like you might have skipped Step #2 below.

    Tutorials and example code are great, but keep this in mind to maximize your success and minimize your frustration:

    How to do tutorials properly, two (2) simple steps to success:

    Step 1. Follow the tutorial and do every single step of the tutorial 100% precisely the way it is shown. Even the slightest deviation (even a single character!) generally ends in disaster. That's how software engineering works. Every step must be taken, every single letter must be spelled, capitalized, punctuated and spaced (or not spaced) properly, literally NOTHING can be omitted or skipped.

    Fortunately this is the easiest part to get right: Be a robot. Don't make any mistakes.
    BE PERFECT IN EVERYTHING YOU DO HERE!!

    If you get any errors, learn how to read the error code and fix your error. Google is your friend here. Do NOT continue until you fix your error. Your error will probably be somewhere near the parenthesis numbers (line and character position) in the file. It is almost CERTAINLY your typo causing the error, so look again and fix it.

    Step 2. Go back and work through every part of the tutorial again, and this time explain it to your doggie. See how I am doing that in my avatar picture? If you have no dog, explain it to your house plant. If you are unable to explain any part of it, STOP. DO NOT PROCEED. Now go learn how that part works. Read the documentation on the functions involved. Go back to the tutorial and try to figure out WHY they did that. This is the part that takes a LOT of time when you are new. It might take days or weeks to work through a single 5-minute tutorial. Stick with it. You will learn.

    Step 2 is the part everybody seems to miss. Without Step 2 you are simply a code-typing monkey and outside of the specific tutorial you did, you will be completely lost. If you want to learn, you MUST do Step 2.


    Of course, all this presupposes no errors in the tutorial. For certain tutorial makers (like Unity, Brackeys, Imphenzia, Sebastian Lague) this is usually the case. For some other less-well-known content creators, this is less true. Read the comments on the video: did anyone have issues like you did? If there's an error, you will NEVER be the first guy to find it.

    Beyond that, Step 3, 4, 5 and 6 become easy because you already understand!

    As you are learning, it is important find a way to get the information you need in order to reason about what the problem is.

    What is often happening in these cases is one of the following:

    - the code you think is executing is not actually executing at all
    - the code is executing far EARLIER or LATER than you think
    - the code is executing far LESS OFTEN than you think
    - the code is executing far MORE OFTEN than you think
    - the code is executing on another GameObject than you think it is
    - you're getting an error or warning and you haven't noticed it in the console window

    To help gain more insight into your problem, I recommend liberally sprinkling Debug.Log() statements through your code to display information in realtime.

    Doing this should help you answer these types of questions:

    - is this code even running? which parts are running? how often does it run? what order does it run in?
    - what are the values of the variables involved? Are they initialized? Are the values reasonable?
    - are you meeting ALL the requirements to receive callbacks such as triggers / colliders (review the documentation)

    Knowing this information will help you reason about the behavior you are seeing.

    If your problem would benefit from in-scene or in-game visualization, Debug.DrawRay() or Debug.DrawLine() can help you visualize things like rays (used in raycasting) or distances.

    You can also call Debug.Break() to pause the Editor when certain interesting pieces of code run, and then study the scene manually, looking for all the parts, where they are, what scripts are on them, etc.

    You can also call GameObject.CreatePrimitive() to emplace debug-marker-ish objects in the scene at runtime.

    You could also just display various important quantities in UI Text elements to watch them change as you play the game.

    If you are running a mobile device you can also view the console output. Google for how on your particular mobile target, such as this answer or iOS: https://forum.unity.com/threads/how-to-capturing-device-logs-on-ios.529920/ or this answer for Android: https://forum.unity.com/threads/how-to-capturing-device-logs-on-android.528680/

    Another useful approach is to temporarily strip out everything besides what is necessary to prove your issue. This can simplify and isolate compounding effects of other items in your scene or prefab.

    Here's an example of putting in a laser-focused Debug.Log() and how that can save you a TON of time wallowing around speculating what might be going wrong:

    https://forum.unity.com/threads/coroutine-missing-hint-and-error.1103197/#post-7100494

    If you truly get stuck on some detail, here is how to report your problem productively in the Unity3D forums:

    http://plbm.com/?p=220

    If you post a code snippet, ALWAYS USE CODE TAGS:

    How to use code tags: https://forum.unity.com/threads/using-code-tags-properly.143875/

    You may edit your post above.