Bug Code generation does not work with generic IComponent types

I'm doing some code generation where I'm having generic component variants like

Code (CSharp):

1.  
2.    [assembly: RegisterGenericComponentType(typeof(GameplayAttributeData<Health>))]
3.  
4.    public struct Health {}
5.  
6.     public struct GameplayAttributeData<T> : IComponentData where T : struct
7.     {
8.         [GhostField]
9.         public float Value;
10.         public float MaxValue;
11.         public float MinValue;
12.     }

This does not work with the current code generator as it produces faulty code of

"...GameplayAttributeData`1GhostComponentSerializer"

"ref var component = ref GhostComponentSerializer.TypeCast<...GameplayAttributeData`1>(componentData, 0);"

Would be nice to know if this is something solved in the future e.g. 0.50 or 1.0

 

Thank you for the reply!

To start of; the IChunkComponent seems very interesting! I guess it separates chunks similar to ISharedComponentData?
However the Min and MaxValues are really irelelvant here for what I'm doing.

What I'm trying to accomplish is very inspired of UE Gameplay Ability System system. To be able to specify gameplay logic dependencies and effects in the editor in an easy way. I have GameplayAffected entities which can have various GameplayAttribute<T>s and can have GameplayAbilities which have GameplayEffects which can have various GameplayAttributeModifier<T>. By this I have a GameplayAttributeModifySystem<T> which sums up modifications by different effects and applies it to attributes. My script generation simply scans project of GameplayAttribute SOs and outputs some code as below. If this would be considered added support for in 1.0 it would be nice to also add "RegisterGenericSystemType".

Thank you!

Code (CSharp):

1. using SpaceCraft.ClientAndServer.GameplayEffects.Modifier;
2. using SpaceCraft.ClientAndServer.GameplayAttributes;
3. using Unity.Entities;
4. using Unity.NetCode;
5.  
6. [assembly: RegisterGenericComponentType(typeof(GameplayAttributeData<Health>))]
7. [assembly: RegisterGenericComponentType(typeof(GameplayAttributeModifier<Health>))]
8. [assembly: RegisterGenericComponentType(typeof(GameplayAttributeData<Shield>))]
9. [assembly: RegisterGenericComponentType(typeof(GameplayAttributeModifier<Shield>))]
10. [assembly: RegisterGenericComponentType(typeof(GameplayAttributeData<Speed>))]
11. [assembly: RegisterGenericComponentType(typeof(GameplayAttributeModifier<Speed>))]
12.  
13. namespace SpaceCraft.ClientAndServer.GameplayAttributes
14. {
15.     public struct Health {}
16.     public struct Shield {}
17.     public struct Speed {}
18.  
19.     [UpdateInGroup(typeof(ClientAndServerSimulationSystemGroup))]
20.     public class GameplayHealthAttributeModifySystem : GameplayAttributeModifySystem<Health> { }
21.     [UpdateInGroup(typeof(ClientAndServerSimulationSystemGroup))]
22.     public class GameplayShieldAttributeModifySystem : GameplayAttributeModifySystem<Shield> { }
23.     [UpdateInGroup(typeof(ClientAndServerSimulationSystemGroup))]
24.     public class GameplaySpeedAttributeModifySystem : GameplayAttributeModifySystem<Speed> { }
25.  
26.     public static class GameplayAttributesUtility
27.     {
28.         public static void AddAttributeToEntity(GameplayAttribute gameplayAttribute, Entity entity, EntityManager dstManager)
29.         {
30.             var attributeName = gameplayAttribute.name;
31.             switch (attributeName)
32.             {
33.                 case "Health":
34.                 {
35.                     dstManager.AddComponentData(entity, new GameplayAttributeData<Health>());
36.                     break;
37.                 }
38.                 case "Shield":
39.                 {
40.                     dstManager.AddComponentData(entity, new GameplayAttributeData<Shield>());
41.                     break;
42.                 }
43.                 case "Speed":
44.                 {
45.                     dstManager.AddComponentData(entity, new GameplayAttributeData<Speed>());
46.                     break;
47.                 }
48.  
49.             }
50.         }
51.     }
52. }
53.  

 

Interesting indeed!

It's by design it is only one value per component here, as it should only be touched by specific systems & only changed by modifiers. For other types I would do GameplayFloatAttribute<T> GameplayIntegerAttribute<T> etc with their seperate but similar generic system, but it is nothing that I see use for now.

In the end I realized I could just do some text template the systems and generate the code for them by hand then doing it generic. But another thing was that I could use a interface on the attribute, and thus being able to keep it generic - as a temporary solution until 1.0.

What I end up with then;

Code (CSharp):

1.     public interface IGameplayAttribute
2.     {
3.         public float GetValue();
4.         public void SetValue(float value);
5.     }
6.  
7.     public struct Health : IGameplayAttribute, IComponentData
8.     {
9.         [GhostField]
10.         public float Value;
11.      
12.         public float GetValue()
13.         {
14.             return Value;
15.         }
16.  
17.         public void SetValue(float value)
18.         {
19.             this.Value = value;
20.         }
21.     }

Which I can then use in a generic system

Code (CSharp):

1.             Entities.ForEach((Entity entity, ref T attribute, in GameplayAttributeData<T> gameplayAttributeData, in DynamicBuffer<GameplayAttributeModifier<T>> modifierBuffer) =>
2.             {
3.                ...
4.             });

(But in a IJobForEachWithEntity for now as Entities.ForEach does not support generic^^)

Though the get and setter probably has some overhead, but something I can live with until it is supported .

Thank you!