Question Code being overwritten when having multiple Rigidbody.MovePosition()

Hi all,

I have written the below script that moves attempts to move a rigidbody on the x, y and z axis, however, it's only moving the object on the z axis (last line) except when I have the 1f value on the z at 0f, so the code is being overwritten by the last line for some reason... how can I rewrite it so it runs all 3 lines simultaneously?

Code (CSharp):

1.         if (x.input != 0.0f)
2.             rb.MovePosition(transform.position + transform.right * 1f * x.speed * Time.deltaTime);
3.  
4.         if (y.input != 0.0f)
5.             rb.MovePosition(transform.position + transform.up * 1f * y.speed * Time.deltaTime);
6.  
7.         if (z.input != 0.0f)
8.             rb.MovePosition(transform.position + transform.forward * 1f * z.speed * Time.deltaTime);

 

This should do what you want. Like Melv said, we first calculate the new position and then call MovePosition once. Note that multiplication with 1 is pointless, it doesn't change the result.

Code (CSharp):

1. Vector3 newPosition = transform.position;
2.  
3. if (x.input != 0f)
4.    newPosition += transform.right * x.speed * Time.deltaTime;
5.    
6. if (y.input != 0f)
7.    newPosition += transform.up * y.speed * Time.deltaTime;
8.    
9. if (z.input != 0f)
10.    newPosition += transform.forward * z.speed * Time.deltaTime;
11.    
12. rb.MovePosition(newPosition);

 

Code (CSharp):

1.  
2. Vector3 wantedOffset = Vector3.zero;
3. if (x.input != 0.0f) wantedOffset += transform.right * 1f * x.speed;
4. if (y.input != 0.0f) wantedOffset += transform.up * 1f * y.speed;
5. if (z.input != 0.0f) wantedOffset += transform.forward * 1f * z.speed;
6.  
7. Vector3 wantedPosition = transform.position + wantedOffset * Time.deltaTime;
8. rb.MovePosition(wantedOffset);
9.  

The code should already speak for itself but yea - accumale your values to a local Vector3 first, then call the MovePosition Method once.
I don't really undestand why you have a speed AND input value, but I don't know how everything else in your code looks like. Tho, I wouldn't compare a float to a value directly, you should use some margin instead, something like

if(Mathf.Abs(x.input) < 0.01f)

as float-values tend to produce some weird numbers from time to time (because of precision issues). It usually works with 0, but as this is an input value, I'd definitely add a margin.

Also I reduced some of the code duplication in my example. I'm a lazy coder, I write as less as possible and when there are changes I want to keep them at the minimum amount of places (in this case, if I want to change deltaTime to e.g. fixedDeltaTime or smoothDeltaTime for some reason, I can do that in one spot instead of 3 now). I guess the

*1f *

is for testing, so I left it at each line.

 

Thank you, Input is for the user/ai input which is -1f to 1f and speed is the multiplier so I need them to be seperate values and I only want to run the move code if there is a input from the user.