chunk.DidChange/DidAddOrChange will never work since it use the current global version

ChangedFilter set on ComponentGroup works because it uses a last system number, the system number of the previous update run. And so it can detect chunk changes occured from the last system run to the current run since they will now have a version number higher than the current last system number.

On the other hand with chunk iteration method, the version number to be compared with chunk's version is captured at GetArchetypeChunkComponentType<T> method. But it captures the current global number, not this system's last version number. Then it is not possible for any previously changed chunk to win over this number since the global number had just been increased right before OnUpdate of the system. It will be 100% higher than any changed chunk's version.

Am I doing something wrong with the chunk iteration? Is calling GetArchetypeChunkComponentType to get the type on every OnUpdate correct? Possibly if this is a bug, this leads to the TransformSystem problem described here https://forum.unity.com/threads/scale-component-not-being-updated.577477/#post-3860479 since chunk's change version was used all over that file.

 

I reported the same thing a while ago though a direct message (@mike_acton) , probably got forgotten due to Unite. I added the last version to the ArchetypeChunkComponentType and use that to fix it for now.

This is the same issue too:
https://forum.unity.com/threads/0-2...-chunk-change-version-not-getting-set.569377/

 

Attached the patch I'm currently using.

 

0.0.12-preview.20 fixes this for DidAddOrChange by adding a version parameter but DidChange is still broken. TransformSystem no longer has this issue.

 

Also whats should go in the new parameter is the newly exposed `LastSystemVersion` protected property of a system.