[Burst] New release 1.3.0-preview.10, we need your feedback!

Would gladly try this new version if only any version higher 1.3.0-preview.7 didn't end up in a crash

 

Would be good to add to Known Issues that NativeArrays don't work in Function Pointers.

 

Exception: This method should have been replaced by codegen

Still getting this error (and i got this error since like half a year already) .. i posted this in the forum but no one answered

This lambda is executed whenever Observable.Interval(TimeSpan.FromSeconds(WorldManager.Instance.CleanupTime))
is outputting a number

Code (CSharp):

1. listener.RegisterOnEvent("name",
2.                 Observable.Interval(TimeSpan.FromSeconds(WorldManager.Instance.CleanupTime)),
3.                 (l, inputDeps) =>
4.                 {
5.                     LoggerSystem.Log("Cleanup");
6.  
7.                     var cmdBuffer = commandBufferSystem.CreateCommandBuffer().ToConcurrent();
8.  
9.                     var middlePoint = GetSingleton<MiddlePointSingleton>().Value;
10.  
11.                     var gridSize = WorldManager.Instance.GridSize;
12.                     var planeSize = WorldManager.Instance.PlaneSize;
13.  
14.                     Entities.WithBurst()
15.                         .WithStructuralChanges()
16.                         .ForEach((Entity entity, int index, ref PlanePosition position) =>
17.                         {
18.                             if (!IdMath.IsPositionInsideCurrentMiddlePoint(position.Position, middlePoint, gridSize,
19.                                 planeSize))
20.                             {
21.                                 cmdBuffer.DestroyEntity(index, entity);
22.                             }
23.                         });
24.  
25.                     commandBufferSystem.AddJobHandleForProducer(inputDeps);
26.  
27.                     return inputDeps;
28.                 });

if i replace the Entities.Foreach method with an already deprecated
IJobForEachWithEntity then it works...

EDIT: behind the scenes in RegisterOnEvent(), ill wrap the whole thing in a lambda again... so i have like 2 nested lambdas

 

My bad you are right! I somehow thought this is related to burst, but ofc its related to entities

 

Yes I Have tried it. I have filled an automatic crash report once. I tested with the default urp template project. With 1.3.0-preview.7 everything is fine. After i update to preview.10 i get this errors

Code (CSharp):

1. System.InvalidOperationException: Burst failed to compile the function pointer `Int32 DoGetCSRTrampoline()`
2.   at Unity.Burst.BurstCompiler.Compile[T] (T delegateObj, System.Boolean isFunctionPointer) [0x00132] in C:\Users\apaxn\Unity Projects\Test\Library\PackageCache\com.unity.burst@1.3.0-preview.10\Runtime\BurstCompiler.cs:176
3.   at Unity.Burst.BurstCompiler.CompileFunctionPointer[T] (T delegateMethod) [0x00000] in C:\Users\apaxn\Unity Projects\Test\Library\PackageCache\com.unity.burst@1.3.0-preview.10\Runtime\BurstCompiler.cs:81
4.   at Unity.Burst.Intrinsics.X86.CompileManagedCsrAccessors () [0x00000] in C:\Users\apaxn\Unity Projects\Test\Library\PackageCache\com.unity.burst@1.3.0-preview.10\Runtime\Intrinsics\x86\Csr.cs:191
5.   at Unity.Burst.Editor.BurstLoader..cctor () [0x00198] in C:\Users\apaxn\Unity Projects\Test\Library\PackageCache\com.unity.burst@1.3.0-preview.10\Editor\BurstLoader.cs:147
6. UnityEditor.EditorAssemblies:ProcessInitializeOnLoadAttributes(Type[])
7.  
8. InvalidOperationException: Burst failed to compile the function pointer `Void AddComponentEntitiesBatchExecute(Unity.Entities.EntityComponentStore*, Unity.Collections.LowLevel.Unsafe.UnsafeList*, Int32)`
9. Unity.Burst.BurstCompiler.Compile[T] (T delegateObj, System.Boolean isFunctionPointer) (at Library/PackageCache/com.unity.burst@1.3.0-preview.10/Runtime/BurstCompiler.cs:176)
10. Unity.Burst.BurstCompiler.CompileFunctionPointer[T] (T delegateMethod) (at Library/PackageCache/com.unity.burst@1.3.0-preview.10/Runtime/BurstCompiler.cs:81)
11. Unity.Entities.StructuralChange.Initialize () (at Library/PackageCache/com.unity.entities@0.9.1-preview.15/Unity.Entities/EntityManagerChangeArchetype.cs:65)
12. Unity.Entities.EntityManager..ctor (Unity.Entities.World world) (at Library/PackageCache/com.unity.entities@0.9.1-preview.15/Unity.Entities/EntityManager.cs:162)
13. Unity.Entities.World..ctor (System.String name, Unity.Entities.WorldFlags flags) (at Library/PackageCache/com.unity.entities@0.9.1-preview.15/Unity.Entities/World.cs:145)
14. Unity.Entities.DefaultWorldInitialization.Initialize (System.String defaultWorldName, System.Boolean editorWorld) (at Library/PackageCache/com.unity.entities@0.9.1-preview.15/Unity.Entities.Hybrid/Injection/DefaultWorldInitialization.cs:101)
15. Unity.Entities.DefaultWorldInitialization.DefaultLazyEditModeInitialize () (at Library/PackageCache/com.unity.entities@0.9.1-preview.15/Unity.Entities.Hybrid/Injection/DefaultWorldInitialization.cs:219)
16. Unity.Scenes.SubScene.OnEnable () (at Library/PackageCache/com.unity.entities@0.9.1-preview.15/Unity.Scenes.Hybrid/SubScene.cs:181)

Then, after editor restart the moment I create SubScene or put an empty object in scene with convertToEntity script and press play editor crashes.

 

Seems like entities 0.7 (the newest version for Unity 2019.3) are not fully compatible for il2cpp:

Spoiler

Code (CSharp):

1. The method `Int32 CalculateEntityCountExecute(Unity.Entities.UnsafeMatchingArchetypePtrList ByRef, Unity.Entities.EntityQueryFilter ByRef)` must have `MonoPInvokeCallback` attribute to be compatible with IL2CPP!
2. The method `Int32 CalculateChunkCountExecute(Unity.Entities.UnsafeMatchingArchetypePtrList ByRef, Unity.Entities.EntityQueryFilter ByRef)` must have `MonoPInvokeCallback` attribute to be compatible with IL2CPP!
3. The method `Void AddComponentEntitiesBatchExecute(Unity.Entities.EntityComponentStore*, Unity.Collections.LowLevel.Unsafe.UnsafeList*, Int32)` must have `MonoPInvokeCallback` attribute to be compatible with IL2CPP!
4. The method `Boolean AddComponentEntityExecute(Unity.Entities.EntityComponentStore*, Unity.Entities.Entity*, Int32)` must have `MonoPInvokeCallback` attribute to be compatible with IL2CPP!
5. The method `Void AddComponentChunksExecute(Unity.Entities.EntityComponentStore*, Unity.Entities.ArchetypeChunk*, Int32, Int32)` must have `MonoPInvokeCallback` attribute to be compatible with IL2CPP!
6. The method `Boolean RemoveComponentEntityExecute(Unity.Entities.EntityComponentStore*, Unity.Entities.Entity*, Int32)` must have `MonoPInvokeCallback` attribute to be compatible with IL2CPP!
7. The method `Void RemoveComponentEntitiesBatchExecute(Unity.Entities.EntityComponentStore*, Unity.Collections.LowLevel.Unsafe.UnsafeList*, Int32)` must have `MonoPInvokeCallback` attribute to be compatible with IL2CPP!
8. The method `Void RemoveComponentChunksExecute(Unity.Entities.EntityComponentStore*, Unity.Entities.ArchetypeChunk*, Int32, Int32)` must have `MonoPInvokeCallback` attribute to be compatible with IL2CPP!
9. The method `Void AddSharedComponentChunksExecute(Unity.Entities.EntityComponentStore*, Unity.Entities.ArchetypeChunk*, Int32, Int32, Int32)` must have `MonoPInvokeCallback` attribute to be compatible with IL2CPP!
10. The method `Void MoveEntityArchetypeExecute(Unity.Entities.EntityComponentStore*, Unity.Entities.Entity*, Void*)` must have `MonoPInvokeCallback` attribute to be compatible with IL2CPP!
11. The method `Void SetChunkComponentExecute(Unity.Entities.EntityComponentStore*, Unity.Entities.ArchetypeChunk*, Int32, Void*, Int32)` must have `MonoPInvokeCallback` attribute to be compatible with IL2CPP!
12. The method `Void CreateEntityExecute(Unity.Entities.EntityComponentStore*, Void*, Unity.Entities.Entity*, Int32)` must have `MonoPInvokeCallback` attribute to be compatible with IL2CPP!
13. The method `Void InstantiateEntitiesExecute(Unity.Entities.EntityComponentStore*, Unity.Entities.Entity*, Unity.Entities.Entity*, Int32)` must have `MonoPInvokeCallback` attribute to be compatible with IL2CPP!

 

The newest compatible with 2019.3 is 0.9.1

 

Oh ye, thanks, somehow my brain started mixing urp requirements with entities.

Spoiler

After updating all packages there are no errors anymore.


One difference I found compared to 1.2.3 is that lib_burst_generated.dll is generated to "Plugins/x86_64" folder even when all other dlls go to "Plugins/" folder. I have to manually move over everything to one folder otherwise project won't work.

In 1.2.3 everything went to "Plugins/" folder and run correctly. I'm building for x86_64 Windows.

 

Tried it, looks like everything is working as expected (including builds without C++ build tools).

 

thank you for the hard work!

 

Case 1240586 older one, Case 1241175 new

 

Basically yes, but they were made with different engine versions.1240586 with 2020.2 and don't have project files,1241175 was made with 2020.1 and include project file.

 

Going to 2019.3.10 from 2019.3.3 fixed the issue, all dlls go to x84_64 folder, thanks!

The "xms elapsed" (since last brake point) makes it better for performance testing than normal debugger. I wish that would also work for non-bursted code.

 

@xoofx would the limited string support, support equivalencies?
Example, I have a ref BlobString variable within a job, can I either:

• switch(variable) with string literals as cases?
• check if(variable.Equals( $"some context + {arg}"))
  
• Or some way to pull the string out of the blob string to do the previous two in burst?

Realistically in my case I have immutable strings in BlobAssets in the form of BlobStrings. I know in a job what the string should be or can construct the matching string, but I'd like to compare a blobstring contents with a string literal if possible.

 

Awesome! Being able to move most of my system to Burst would be amazing! Strings are pretty much the largest component of the current limitations. The switch statement was mostly a hopeful thought, but understandable as to why it isn't necessarily supported

Also out of curiosity, would being able to compare NativeStrings to FixedStrings be a feasibility in burst?

 

Hello there!

Having Debug.Log support in burst was much needed, so this is a pretty good addition!
Would it be possible in the future to forward managed string literals to our own static methods without converting to FixedString somehow?

Having Debug.Log support is awesome, but in our case we often have wrappers around the Log API (e.g. for conditional compilation or to redirect logging) so we would want to pass the string around in a method call and only format later on if needed, or store that in a ring buffer for later processing.
Having to deal with FixedStrings for what is essentially a constant fixed array of chars feels weird, essentially we would want the same functionality as Debug.Log() but without using Debug.Log, and we can deal with any limitation such as not using any string methods or storing the string in a native array format


Other than that, I also have some general feedback regarding using burst with Entities.ForEach, which might not be *directly* related to burst, so I'll quickly mention them:

• NativeArray<T> would benefit from ref indexer ("ref T this[int index]"), something we can already do with UnsafeUtilityEx.ArrayElementAsRef<T>() but having it directly in the NativeArray would be nice
• Would also be nice if we could force the capture of variables by copy in lambdas (something like [=]() { } in C++) instead of having to declare copies in the calling method, though I understand that this may become error-prone as it bends the language even more, but oh well, we're already far enough, aren't we?

Thanks!
Christopher.

 

hi @xoofx, are you able to give any update on cross-platform deterministic floats in the Burst compiler? Is it still being worked on?

 

Thanks for the reply @tim_jones. I was wondering as Joachim previously mentioned the burst compiler will support cross platform floating point determinism end 2019 / early 2020 so was hoping for an update but I appreciate that priorities can change and schedules move. Great work so far.

 

After updating from p7 to p10, one of our developers is now getting a

Unhandled exception at 0x00007FFFE18F171D (2434e8347f5ac492b9b5fcdc29e9a4d5.dll) in crash.dmp: 0xC000001D: Illegal Instruction. occurred

crashing his editor every time he tries to play.

The line of assembly looks like this



He's using an older i5-3470 which doesn't support avx2, but it seems to be using it for him in editor anyway?

 

Maybe you had same issue. @apaxnid what's your cpu?

 

I have corei7 3630qm and I got an answer to my issue

 

I filed 1237423 for preview9 which is a crash with sub scenes and it still shows as open. Was also a thread on this. Any ETA on when a fix will land?

 

preview-11 after restarting at first didn't compile my jobs. I had burst safety check off. Turned them on and went into play mode and it crashed. Editor logs didn't show much stack trace had a single unhelpful line.

Just did that once on me so far, maybe had issues with cached old data or something?

Sub scenes didn't crash on me.

 

Everything works fine now, no more crashes

 

I'm getting a crash any time I try and use the X86.Avx.mm256_cvtepi32_ps intrinsic. Simply viewing it in the Burst inspector crashes Unity. Using preview 12 now, 2020.1.0b8. Case ID is 1245193