Bug with Undo functionality while binding.

TLDR Version- I want to know whats the best way to display Propertyfield's of SerializedFields of an EditorWindow class without creating ghost Undo's that are still present once the EditorWindow is deleted.

Detailed Version:
The way I first tried to display fields for a serialized variable of the editor window object was to use a Property Field bound(or binded?? I dont know lol) to the variable because EditorWindows inherit from Scriptable Object and everything seemed to work fine. I make changes in the Editor Window and it updates the variables and vice versa, and Undo works just as expected too.

But the problem starts to show up once the Editor Window is deleted. An Undo is registered when I change a property field, and the undo persists even after closing the Editor Window. So if I open an Editor Window and make like around 20 changes and then close the window, now if I want to revert the editor back to how it was before opening the Editor Window, I would have to Undo 20 times for no reason, because the Editor Window doesnt reopen too when you Undo.

The Undo's name is "Undo Inspector", so basically I would have 20 blank 'Undo Inspector' undos because the Editor Window is no longer open.

So can some tell me a better way to do this? Removing the Undos for an object once the concerned object is deleted should be a built in thing unless explicitly told to not happen with Undo.DeleteObject or whatever that function is cant remember it correctly atm.

Steps to recreate this issue:

Step 1: Opening the Editor Window for the first time




Step 2: Changing a value


Step 3: Checking out the undo created for the change


Step 4: Doing the change for like 10 times(Repeat of Step 2)

Step 5: Closing the Window



Step 6: Check that the undo still persists as a ghost Undo(not one but ten of these because we changed value like ten times), but we dont want that!!




My Editor Window Script:

Code (CSharp):

1.  
2. using UnityEditor;
3. using UnityEditor.UIElements;
4. using UnityEngine;
5.  
6. public class TestEditorWindow : EditorWindow
7. {
8.     #region Variables
9.     private static TestEditorWindow s_Window;
10.     [SerializeField] private float m_TestFloat;
11.     #endregion
12.  
13.     [MenuItem("Test Editor Window/Open")]
14.     public static void OpenWindow_F()
15.     {
16.         if (s_Window != null) s_Window.Close();
17.         s_Window = CreateWindow<TestEditorWindow>();
18.     }
19.  
20.     private void OnEnable()
21.     {
22.         UICreate_F();
23.     }
24.  
25.     private void UICreate_F()
26.     {
27.         PropertyField propertyField0 = new PropertyField();
28.         propertyField0.BindProperty(new SerializedObject(this).FindProperty("m_TestFloat"));
29.         rootVisualElement.Add(propertyField0);
30.     }
31. }
32.  

There's another... i guess its a bug im not really sure but creating a property field and binding it to a serializedProperty through the constructor parameters dont work, the property field is not displayed at all.

Code (CSharp):

1. PropertyField propertyField0 = new PropertyField(new SerializedObject(this).FindProperty("m_TestFloat"));
2.  
3. rootVisualElement.Add(propertyField0);
4.  

But it works if I bind it using the BindProperty method of the PropertyField.

Code (CSharp):

1. PropertyField propertyField0 = new PropertyField();
2. propertyField0.BindProperty(new SerializedObject(this).FindProperty("m_TestFloat"));
3. rootVisualElement.Add(propertyField0);

Nothing major but a one liner becomes a three liner because of this .

 

Sorry for the late reply, but yeah, I was using Undo.RegiserCompleteObjectUndo like u said before, but it would have been better if it happened automatically and I felt it wasnt worth it to do it like that. But if Undo works that way, then I guess i'll just have to deal with it.

Thanks you for clearing my doubts!