Bug (v0.4.6-preview): CreateEditor() invocation every frame in AddressableAssetGroupInspector.cs

Hullo,

Hope this is the right place to report bugs - couldn't really find anywhere else, but if I'm in the wrong place, just let me know

I'm an Odin dev, and a little bug hunt regarding reported Odin incompatibilities with the addressables system led me down this rabbit hole. In essence, whenever an AddressableAssetGroup is inspected and Odin is the editor for any of the inspected schemas, the implementation of AddressableAssetGroupInspector will mess thing up by creating a new Editor instance every frame for every group schema it contains. This issue isn't just isolated to anything specific to Odin, but will affect a broader range of editors.

The problematic code is on line 94 of the AddressableAssetGroupInspector.cs file in the 0.4.6-preview package: CreateEditor(schema).OnInspectorGUI();

I haven't checked on any other versions yet, but we've had it reported from as far back as 0.4.0.

A suggested fix (and optimization) would be to create and cache the required editors in the first Layout event when they're necessary, so you're not instantiating/resetting (disable/enable if editor caching steps in) new editors on every single GUI event or even every GUI layout>events>repaint loop, which will cause issues with any editors that rely on keeping state across several GUI events, such as Odin's editors. It's a terrible "quick-n-dirty" inspector hack that I've seen in many places before, and as always, it's causing issues for everyone involved.

Cheers!

 

Would love to see this fixed, and I think a lot of other people might too, given that Unity has offered Odin inspector as a freebie for renewing your unity subscription early.

 

Any update on this? It seems to have gone largely unacknowledged - should this be reported through the in-engine bug reporter somehow, instead?

 

That's why this code should be open sourced too !

 

Alright, cheers, thanks. I'll make sure to use the bug reporter if I run into anything else, then.

 

I use
Addressables: 0.4.8-preview
Odin - Inspector: 2.0.13

Still the same Error, are there any updates now?