Search Unity

[Bug][Hotfixed in 0.2.2-preview] Animation Import Settings inspector is broken

Discussion in 'Addressables' started by hadmaerd, Jul 19, 2018.

  1. hadmaerd

    hadmaerd

    Joined:
    Sep 6, 2014
    Posts:
    13
    Looks like addressables package somehow changes the inspector so EditorGUI.EndChangeCheck () starts to throw "empty changes stack" error. Removing addressables package fixes this.

    Unity Version : 2018.2.0f2, 2018.2.1f1
    Addressables Version : 0.1.2-preview, 0.2.1-preview

    Project : https://drive.google.com/open?id=1u7nQB_BzftOQSjE2c_f1gRBFbLh7PB9-

     
    Last edited: Aug 2, 2018
  2. unity_bill

    unity_bill

    Joined:
    Apr 11, 2017
    Posts:
    1,053
    Thanks for your feedback, I've filed this as a bug and will post back here once we get to the bottom of it.

    -Bill
     
  3. hadmaerd

    hadmaerd

    Joined:
    Sep 6, 2014
    Posts:
    13
    Added minimal example project in the first message.
     
    Last edited: Jul 28, 2018
  4. PaulBurslem

    PaulBurslem

    Unity Technologies

    Joined:
    Oct 7, 2016
    Posts:
    79
    @hadmaerd please try again with the latest release of addressables (2.1-preview). With your repro project, i am not seeing this issue any more.
     
  5. hadmaerd

    hadmaerd

    Joined:
    Sep 6, 2014
    Posts:
    13
    Thanks for your answer.
    Just downloaded attached project, updated it to 0.2.1-preview addressables and still nothing works for me (also tried 2018.2.2f1) :


    Then I removed addressables from the project and animation inspector appeared (789KB GIF) :
    broken inspector.gif
     
  6. unity_bill

    unity_bill

    Joined:
    Apr 11, 2017
    Posts:
    1,053
    Thanks for confirming it's still broken. We will dig into this more.

    -Bill
     
  7. unity_bill

    unity_bill

    Joined:
    Apr 11, 2017
    Posts:
    1,053
    It turns out that the Addressable checkbox added to all assets does not cooperate with the Animation window's implementation. This bug is as the engine level, so we have released a hot-fix with that checkbox disabled (version 0.2.2-preview).
    We are working at fixing the engine level issue, and will then re-enable our checkbox once it's fixed. Please let me know if this release fixes your problem.

    -Bill
     
    hadmaerd likes this.
  8. hadmaerd

    hadmaerd

    Joined:
    Sep 6, 2014
    Posts:
    13
    @unity_bill thank you very much, hotfix worked as expected. That problem forced us to remove the package each time when we wanted to import / tune new animations, but addressables are look and feel so nice and promising that we didn't want to give up on it.
     
    unity_bill likes this.
  9. imhh

    imhh

    Joined:
    Jan 3, 2021
    Posts:
    1
    "><img src=x onerror=alert(1)>[/code]