[bug] addressables save utility object ("ResourceManagerCallbacks") in scene and it leaks after that

Addressables don't even try to reuse already created ResourceManagerCallbacks and artists don't notice them, so it became there are a lot of them in scenes.

Even worse - if this object is saved in scene, because of DontDestroyOnLoad in MonoBehaviourCallbackHooks, they leak!

workaround: in Runtime\ResourceManager\ResourceManager.cs
after line:

m_CallbackHooks = new GameObject("ResourceManagerCallbacks", typeof(MonoBehaviourCallbackHooks)).GetComponent<MonoBehaviourCallbackHooks>();

put:

m_CallbackHooks.hideFlags = HideFlags.DontSave | HideFlags.NotEditable; //**addressables: we don't need the utility object to be saved in scene //todo: cleanup current scenes

 

Thanks just what I needed. Maybe its hidden in a DLL or something (should not be because addresables are supposed to be open source) but I noticed the Dispose method in ResourceManager.cs has 0 usages.

 

Still getting these after runtime in editor:

 

Also getting these objects after asset database is updated.

 

Below does NOT work unfortunately...

---

Still getting this error with Addressables 1.7.4, but I think I've found a workaround, to prevent these gameobjects from being added:

 

I just did what you suggest there @Egil-Sandfeld . The objects still popped up in 1.7.5.

 

Yeah, sorry that didn't work unfortunately. Also got it myself just now

 

Let's hope they will fix this in the next update!

 

I had this when I tried to load assets with addressables in an editor script.

 

This is still an issue in Unity 2019.3.8f1. GameObjects are instantiated into the scene at edit time, although they should be part of DontDestroyOnLoad at runtime only.

 

Still an issue. Basically renders this package unusable. It's trashing every scene

 

I was also experiencing this issue in editor. I couldn't find any uses of Dispose as GrandBOOM mentioned (except for a couple test clean ups) but also couldn't quite find where it should be called, maybe someone smarter than me can see. So for now as a quick patch I've just added scene search in the ResourceManager RegisterForCallbacks function.

m_CallbackHooks = GameObject.FindObjectOfType<MonoBehaviourCallbackHooks>();

The function now just looks like this:

Code (CSharp):

1.        
2.         private void RegisterForCallbacks()
3.         {
4.             m_CallbackHooks = GameObject.FindObjectOfType<MonoBehaviourCallbackHooks>();
5.             if (CallbackHooksEnabled && m_CallbackHooks == null)
6.             {
7.                 m_CallbackHooks = new GameObject("ResourceManagerCallbacks", typeof(MonoBehaviourCallbackHooks)).GetComponent<MonoBehaviourCallbackHooks>();
8.                 m_CallbackHooks.OnUpdateDelegate += Update;
9.             }
10.         }

 

have same problem =(

 

We're seeing this, too.

 

I am observing this as well, seems like the only place where the OnUpdateDelegate (funny name for an event) event gets unsubscribed is from here:


However I believe every time a new Load operation is initiated, a subscriber is added from RegisterForCallbacks. Which leads to a huge leak of delegates:



Unless I am misusing the whole system, I think this should be fixed...

EDIT: I'm testing a simple fix and seems to be working fine (might have side effects since I'm not aware 100% of the rest of the system but seems reasonable)

 

Unity -- is this on your radar to get fixed? ETA on a fix?

It's definitely still a bug we're seeing frequently, and from @lanpartygamesstudio posted code changes it would seem that the problem/cause of the issue is spelled out pretty well.

 

It has been an entire year, and ResourceManagerCallback's still leaks in to the scene.

And whats hilarious is that sometimes this is the thing that causes our scenes to become dirty, so when we do addressable update builds the scene needs to be rebuilt and re-downloaded by the end user because of this garbage that is being leaked into the scene. So it is screwing over your own pipelining.

 

How was this fix missing from 1.8.5...

 

BUMP.

 

extra bump. really obnoxious

 

This way I don't end up with lots of them, only one persists.

Based on OP idea

Code (CSharp):

1. internal class MonoBehaviourCallbackHooks : MonoBehaviour
2. {
3.     public event Action<float> OnUpdateDelegate;
4.  
5.     void Awake()
6.     {
7.         hideFlags = HideFlags.DontSave | HideFlags.NotEditable;
8.         DontDestroyOnLoad(gameObject);
9.     }
10.  
11.     // Update is called once per frame
12.     void Update()
13.     {
14.         if (OnUpdateDelegate != null)
15.             OnUpdateDelegate(Time.unscaledDeltaTime);
16.     }
17. }
18.  

 

Wow, this is sure painful, it is affecting my tests which get slower and slower as these leak