[Bug][1.6.2] Hash collisions in BuildScriptPackedMode

Hello we have been stuck on 1.3.8 for a while because we got errors when building bundles. Today I looked into the problem and found this part of code:

BuildScriptPackedMode:391

Code (CSharp):

1. for (int i = 0; i < bundleInputDefs.Count; i++)
2. {
3.     string assetBundleName = bundleInputDefs[i].assetBundleName;
4.     if (aaContext.bundleToAssetGroup.ContainsKey(assetBundleName))
5.     {
6.         int count = 1;
7.         var newName = assetBundleName;
8.         while (aaContext.bundleToAssetGroup.ContainsKey(newName) && count < 1000)
9.             newName = assetBundleName.Replace(".bundle", string.Format("{0}.bundle", count++));
10.         assetBundleName = newName;
11.     }
12.  
13.     string hashedAssetBundleName = HashingMethods.Calculate(assetBundleName) + ".bundle";
14.     m_OutputAssetBundleNames.Add(assetBundleName);
15.     m_AllBundleInputDefs.Add(new AssetBundleBuild
16.     {
17.         addressableNames = bundleInputDefs[i].addressableNames,
18.         assetNames = bundleInputDefs[i].assetNames,
19.         assetBundleName = hashedAssetBundleName,
20.         assetBundleVariant = bundleInputDefs[i].assetBundleVariant
21.     });
22.     aaContext.bundleToAssetGroup.Add(hashedAssetBundleName, assetGroup.Guid);
23. }

I get a key exception on the last add. I think the line

string hashedAssetBundleName = HashingMethods.Calculate(assetBundleName) + ".bundle";

is wrong because the whole testing with ContainsKey is on a different string than the one that is added. When removing the line and adding assetBundleName instead, the build run fine.

Do I miss something?

 

I'm using 2019.3.2f1 but we had this issue also in older versions like some 2019.2.x

 

@DavidUnity3d thank you. It was not that bad I could easily "fork" the package into a local one

 

I have a another 'fix': BuildScriptFastMode:144

Code (CSharp):

1. if (string.IsNullOrEmpty(entry.AssetPath))
2. {
3.     return $"{assetGroup.name} has an entry with null or empty path. Address: {entry.address}";
4. }
5.  
6. FileAttributes file = File.GetAttributes(entry.AssetPath);
7. if (file.HasFlag(FileAttributes.Directory))
8. {
9.     GatherAssetsForFolder(entry, aaContext);
10. }
11. else
12.     entry.CreateCatalogEntries(aaContext.locations, false, typeof(AssetDatabaseProvider).FullName,
13.         null, null, aaContext.providerTypes);

The if prevent path is empty exception when the asset has been removed / deleted.