Bug Brush Mask Filter Unity 2021.2.16f1 - Terrain Tools Version 4.0.3

Unity 2021.2.16f1 - Terrain Tools Version 4.0.3

Repro:
- Create a new project based on the HDRP Empty template
- Add Terrain Tools v4.0.3 package
- Create terrain
- Click on "Paint Terrain" (if not already selected)
- notice error messages

The issue comes up with all modes where you can set Brush mask filters

WORKAROUND:
I can add *any* filter, and disable it, then the error goes away.


The two errors that show up when I click on the terrain:

Code (CSharp):

1. Retrieving array element that was out of bounds
2. UnityEditor.TerrainTools.FilterStackView:ElementHeightCB (int)
3. UnityEditorInternal.ReorderableList:CacheIfNeeded ()
4. UnityEditorInternal.ReorderableList:GetListElementHeight ()
5. UnityEditorInternal.ReorderableList:DoLayoutList ()
6. UnityEngine.GUIUtility:ProcessEvent (int,intptr,bool&)

Code (CSharp):

1. NullReferenceException: Object reference not set to an instance of an object
2. UnityEditor.TerrainTools.FilterStackView.GetFilterAtIndex (System.Int32 index) (at Library/PackageCache/com.unity.terrain-tools@4.0.3/Editor/TerrainTools/FilterStack/FilterStackView.cs:413)
3. UnityEditor.TerrainTools.FilterStackView.ElementHeightCB (System.Int32 index) (at Library/PackageCache/com.unity.terrain-tools@4.0.3/Editor/TerrainTools/FilterStack/FilterStackView.cs:221)
4. UnityEditorInternal.ReorderableList.CacheIfNeeded () (at <ed149e892fca4713a3001773d054b5ca>:0)
5. UnityEditorInternal.ReorderableList.GetListElementHeight () (at <ed149e892fca4713a3001773d054b5ca>:0)
6. UnityEditorInternal.ReorderableList.DoLayoutList () (at <ed149e892fca4713a3001773d054b5ca>:0)
7. UnityEditor.TerrainTools.FilterStackView.OnGUI () (at Library/PackageCache/com.unity.terrain-tools@4.0.3/Editor/TerrainTools/FilterStack/FilterStackView.cs:111)
8. UnityEditor.TerrainTools.BaseBrushUIGroup.OnInspectorGUI (UnityEngine.Terrain terrain, UnityEditor.TerrainTools.IOnInspectorGUI editContext, UnityEditor.TerrainTools.BrushGUIEditFlags brushFlags) (at Library/PackageCache/com.unity.terrain-tools@4.0.3/Editor/TerrainTools/BrushControllers/BaseBrushUIGroup.cs:454)
9. UnityEditor.TerrainTools.PaintHeightTool.OnInspectorGUI (UnityEngine.Terrain terrain, UnityEditor.TerrainTools.IOnInspectorGUI editContext) (at Library/PackageCache/com.unity.terrain-tools@4.0.3/Editor/TerrainTools/PaintHeightTool.cs:75)
10. UnityEditor.TerrainInspector.ShowPaint () (at <ed149e892fca4713a3001773d054b5ca>:0)
11. UnityEditor.TerrainInspector.OnInspectorGUI () (at <ed149e892fca4713a3001773d054b5ca>:0)
12. UnityEditor.UIElements.InspectorElement+<>c__DisplayClass59_0.<CreateIMGUIInspectorFromEditor>b__0 () (at <182296579622473385aae82a7777a7d5>:0)
13. UnityEngine.GUIUtility:ProcessEvent(Int32, IntPtr, Boolean&)
14.  

Issue tracker ref: https://fogbugz.unity3d.com/default.asp?1411980_o6ensdn4752q6ocd

 

Just wanted to add, exact same version, exact same errors. Same happened with 2020.3.31f1 for me, which is why I upgraded so far up, still had the issue!

Update: Was able to stop the errors, but still not able to sculpt. Most say read only, and if it doesn't it still doesn't draw.

 

(You didn't say, I'm just assuming) After you added the filter, did you disable it? An active filter might be the reason why you can't sculpt. You have to click the eye icon, if it's crossed out it's disabled (and you should be able to draw)

 

Yes, i disabled it. The only aspect i didn't copy, was putting it on every single tab, since there are a lot of options and since it wasn't working, it seemed like i was wasting my time.

 

This only seems to work for me once before having to apply the hotfix. Is there any hope for a permanent solution or should I just write off this entire package? Even actions as simple as undo throw errors into the console.

 

I change to unity 2021.2.14, error disapear

 

That's not much solace for those of us using the LTS branch, which is allegedly supported, for a reason.

 

Still happens in 2021.2.17f1

 

I guess this bug is caused by unity editor property class.I have a plugin have same bug.So, i have to fixed it. For terrain tools, you can copy the package folder to [your unity project]/packages , and then, find FilterStatckView.cs, modify as image:

 

before that, you need copy TerrainTools package to desktop, and remove the package from unity package manager, then copy desktop package to [your unity project]/packages, so that you can modify like image

 

Well technically, the terrain tools are in preview packages which may or may not have issues on LTS.

 

There's a difference between "having issues" and "this tool literally errors out if you perform the most basic of tasks"

 

This still the case in 2021.2.19f1. I sure am curious why this isn't fixed yet. Unless there are some integration issues with this asset, this is only a few lines of code to fix.

 

Same problem in 2022.1.0b15.2990 Except it gets worse, the terrain won't raise or lower properly.
Honestly, I can't even find a stable editor version to make a game lol.

 

Hi, Thanx a lot BigBrotherLee, its worked for me

 

Whoever built these tools at Unity, pleaaaase look into that issue, that'd super appreciated.

 

Just updated to the LTS version and the issues is still not fixed. Terrain Tools is advertised in the release video around the 41 second mark:

Can we please get a confirmation that Unity is working on the issue or is there a problem reproducing it? Can we help somehow?

Pinging @DanielTG because you're the last person from the Team to answer on this forum, sorry for the ping but I'd like to have some visibility on this issue.

 

Anyone else having problems with the Terrain Samples from the asset store link?
They caused Unity to get stuck in a spiral of 'invalid package dependencies' spiral and I ended up nuking my project entirely.

 

I am using 2021.3LTS

This asset link is found here:

 

2021.3.1 The error still exists

 

I am working on the Latest 2021 LTS HDRP but I can't see the brush mask options. Any Help

 

Terrain tools also stopped working for me, with the same errors as mentioned above. I feel like I tried everything, but when I use the Raise/lower terrain and the paint textures when Terrain Tools are enabled the brushes become sort of glitchy (like they are flickering between large and small size for no apparent reason, and don't actually do what they're supposed to do) while I get the same errors as mentioned above. This is a completely new issue for me and very frustrating!

 

When I change the option terrain texture to raise or lower or any other option this error occur. Aftet that I need to select any other game object and back terrain again. My screen is 4k.

 

I am sorry. Can you or anybody explain where can I find that file? I tried but cannot find it.

 

Hello,

This method worked for me:

1. First BackUp your project, and exit from Unity

2.
Copy the original package TerrainTools4.0.3 an another folder (example x:/UBUGFIX/PatchedTerrainTools4.0.3)
Copy from:
X:\YourProject\Library\PackageCache\com.unity.terrain-tools@4.0.3\

3.
Change or modify the following file in the saved package directory x:/UBUGFIX/PatchedTerrainTools4.0.3 (FilterStackView.cs)
X:\YourProject\X_2021_2\Library\PackageCache\com.unity.terrain-tools@4.0.3\Editor\TerrainTools\FilterStack\FilterStackView.cs
Need modify this filter:
private Filter GetFilterAtIndex(int index)
{
//Bug 2022
//return m_FiltersProperty.GetArrayElementAtIndex(index).objectReferenceValue as Filter;
if (m_FiltersProperty.arraySize <= index) { return null; }

var v = m_FiltersProperty.GetArrayElementAtIndex(index);
if (v == null) { return null; }
return v.objectReferenceValue as Filter;
}

4.
Modify the manifest.json file in your project (add the follwing line where file: x:/UBUGFIX/ is your modificated "BugFixed" version of Terrain tool package)
X:\YourProject\Packages\manifest.json
Add this line
"com.unity.terrain-tools": "file:x:/UBUGFIX/PatchedTerrainTools4.0.3/",

This package redirection needed, otherwise if you reopen the project its download and overwrite it.

Hope its help, Good luck

 

Thank you for your reply! I am not sure, maybe I don't understand right. I tried but had some issues. Can I ask you in more details if it is possible when your answer was very detailed.

I need to copy the com.unity.terrain-tools@4.0.3\ folder to the desktop, so there won't be a folder in the original pathway, I mean in in PackageCashe? Or should I just duplicate it to desktop?

If the second sentence is right, should I change that file FilterStackView.cs only in the desktop folder or in both?

Because I am making all this steps this evening and I think I make smth in a wrong way.
- I moved that folder to desktop. Changed that file. Then modified JSON file with the path to that package on desktop. And then redirected that folder to original PackageCache folder.
And there was an error while opening the project, that there was a mistake in json file.
What I am making wrong?
Sorry for the most nubiest question, it is the first time I have errors that don't let me to continue working on my project.
Thank you so much for your attention!

 

Hi Anothervictoriaa,

I used Unity version 2021.2.19f1 (but i think its work on other version too)

Just make a copy from original TerrainTool and modify the copy. Let the original folder and content on the place.
If at project open You got manifest.json file error, maybe the modified path not correct in the json file, or missing "," comma or forgot change backslast "\ " to "/" slash.
Need use a right text editor like Notepad++

I send You a detailed PM (check your inbox) its contain another example.

Have a nice day

 

I got the same issue, also when I change mode from paint texture to set height for example, it crashes the inspector till i minimize the terrain component. 2021.3.2f1
In my case I updated project from 2020.3.23f1, Jitter value is set to 0 by default. Probably Terrain Sample asset pack made the errors.

 

I just want to add, that we are seeing the same things using URP in Unity 2021 LTS.

 

This worked for me and has taken away hours of pain. Thank you very much for taking the time to document it here.

@Wyatt_ you said Unity was looking into it in April, a solution is provided here in May. Can you please ensure that this is patched as soon as possible. It's not an edge case, even if the provided solution has some side effects the package is more usable with it than without.

 

I got an update from the Unity support saying that (and I'm paraphrasing) they are unable to repro the issue... When @wyattt_ you were clearly able to repro, could we please get a (real) update?

 

Hi SorraTheOrc,

I just follow BigBrotherLee instructions.
Thx your feedback, I'm glad I could help.

 

we have the same error for Unity 2021.3.8

 

@wyattt_ In which versions these errors are fixed?. I am using 2021.3.2 and same errors. I am using BIRP and terrain tools 4.0.3

 

Im still having the issue

 

5.x isn't available in Unity 2021 LTS, unfortunately. They made a major release out of it rather than a patch it seems.

 

I seee, any info when it might get released?

 

I'm still stuck at step 4. It always return error duplicated keys in near D:/

 

[POSSIBLE SOLUTION]

This is what I have done to fix this issue:

First of all I worth to mention that I was using 2021.3.10f1 and a HDRP project. Terrain tool was working fine (with some issues placing grass/trees) at the begining but kinda sorted. For some reason after a couple of weeks the terrain tool was throwing at me this error and here I am. And after reading most of the comments and not understanding anything... I decided to uninstall the terrain tool, upgrade from 21.3.10 to 21.3.20 and it worked.

Do not install the terrain tool again from the package manager as it will throw the errors again. And yes, it is weird but you still have the terrain tool without the package being installed or removed.

I hope it helps.

 

Sorry for the late reply

Maybe at step 4 your manifest.json file somwhere contains this row (not sure just an idea)
"com.unity.terrain-tools": "4.0.3",

Remove it and try using (where the x:/UBUGFIX is your path)
"com.unity.terrain-tools": "file:x:/UBUGFIX/PatchedTerrainTools4.0.3/",

EDIT:
I have not experienced this bug in Unity 2021.3.14f1 LTS version
Terrain Tools working well.

At upgrade I create a new clear project, install the components, what i use.
After this, copy my own (created) assets to this clear project.

My opinion this is the best clear upgrade, with this solution i have no problems.
You can copy (transfer) the Layer, Physics, TAG settings from YourProject\ProjectSettings\ folder