Search Unity

  1. Welcome to the Unity Forums! Please take the time to read our Code of Conduct to familiarize yourself with the forum rules and how to post constructively.
  2. Unite 2023 Registrations are now LIVE! We are thrilled to announce that Unite 2023 Registration is now live and open for all!
    Dismiss Notice
New Forum User Notice Unite 2023 Registrations are now LIVE!

Bug Badly Generated Code for GhostComponentSerializer for data using > 64 ChangeMaskBits

Discussion in 'NetCode for ECS' started by Jawsarn, Sep 12, 2023.

  1. Jawsarn

    Jawsarn

    Joined:
    Jan 12, 2017
    Posts:
    214
    SerializeSnapshot & Deserialize increase the startOffset and decrease ChangeMaskBits by 32 only once as it calls GhostComponentSerializer.CopyFromChangeMask to get the correct changeMask resulting in badly serialized data. It should increase it after every call resulting in 32->64->96 offset. CalculateChangeMask seems to be doing this correctly.
     
    Jawsarn, Sep 12, 2023
    #1

  2. CMarastoni

    CMarastoni

    Unity Technologies

    Joined:
    Mar 18, 2020
    Posts:
    743
    IIRC correctly we recently fixed that issue, but I may have understood that incorrectly.
    The generated code for the serialiser does not increment the startOffset itself, but introduce every 32 change mask bits something like:
    Code (csharp):
    1.  
    2. GhostComponentSerializer.CopyFromChangeMask(
    3. changeMaskData, startOffset + __GHOST_CHANGE_MASK_BITS__, ChangeMaskBits - __GHOST_CHANGE_MASK_BITS__)
    4.  
    The __GHOST_CHANGE_MASK_BITS__ is actually the incrementing variable (32,64,96...)

    Se a generated serialiser looks like:

    Code (csharp):
    1.  
    2. var changeMask.= GhostComponentSerializer.CopyFromChangeMask(changeMaskData, startOffset, ChangeMaskBits)
    3. if(xxx..)
    4.   dataStream.Write(..)
    5. ...
    6. //after 32 change bits
    7. changeMask = GhostComponentSerializer.CopyFromChangeMask(changeMaskData, startOffset + 32, ChangeMaskBits - 32);
    8.  
    Can you please copy here the code of one of these generated ghost serialiser that are incorrectly handling this? Even better if you can open a case for this.
     
    CMarastoni, Sep 18, 2023
    #2

  3. Jawsarn

    Jawsarn

    Joined:
    Jan 12, 2017
    Posts:
    214
    Correct, in SerializeSnapshot and Deserialize the __GHOST_CHANGE_MASK_BITS__ only does the first 32, and does not increment to 64,96 etc.

    If you still need a case I'll try make a small project and submit at end of day.
     
    Jawsarn, Sep 18, 2023
    #3

  4. CMarastoni

    CMarastoni

    Unity Technologies

    Joined:
    Mar 18, 2020
    Posts:
    743
    which version of Netcode for Entities are you using? (just to be sure) The latest one?
     
    CMarastoni, Sep 18, 2023
    #4

  5. Jawsarn

    Jawsarn

    Joined:
    Jan 12, 2017
    Posts:
    214
    I'm on 1.0.15, I didn't see the new version. Do you know if it would be fixed in that one? It did not specify in change log.
     
    Jawsarn, Sep 18, 2023
    #5