Search Unity

Question Assets/Turret.cs(52,2): error CS1513: } expected

Discussion in 'Scripting' started by SuperWolf770, May 31, 2022.

  1. SuperWolf770

    SuperWolf770

    Joined:
    Nov 28, 2021
    Posts:
    1
    Hi
    I'm a beginner programmer and I make a game and in the game, there is a turret and the script works fine in the unity, but when I want to build the game in the editor window I became an error: Assets/Turret.cs(52,2): error CS1513: } expected Can you please help me?



    public class Turret : MonoBehaviour
    {

    public MountPoint[] mountPoints;
    public Transform target;
    void OnDrawGizmos()
    {
    #if UNITY_EDITOR




    foreach (var mountPoint in mountPoints)
    {
    var hardpoint = mountPoint.transform;
    var from = Quaternion.AngleAxis(-mountPoint.angleLimit / 2, hardpoint.up) * hardpoint.forward;
    var projection = Vector3.ProjectOnPlane(target.position - hardpoint.position, hardpoint.up);


    }
    }

    #endif
    void Update()
    {
    // do nothing when no target


    // aim target
    var aimed = true;
    foreach (var mountPoint in mountPoints)
    {
    if (!mountPoint.Aim(target.position))
    {
    aimed = false;
    }
    }

    // shoot when aimed
    if (aimed)
    {
    FindObjectOfType<Gun>().Fire();

    }
    }
    }
     
  2. MelvMay

    MelvMay

    Unity Technologies

    Joined:
    May 24, 2013
    Posts:
    11,497
    The best advice I can give to a beginner programmer is to try to understand the basic rules of the language. Here in C# you need to ensure that any opening braces/brackets such as "{" or "(" are matched with closing ones such as "}" and ")".

    The compiler here is telling you the line (52) and column (2) where it expected a closing "}" but didn't find it so look there and before it. Ensure they all match. Also, just searching for this error online will tell you the same thing so there should be no need for you to have to stop and wait on a post in a forum. :)

    NOTE: You should always use code-tags when posting code and not plain text.
     
  3. van800

    van800

    JetBrains Employee

    Joined:
    May 19, 2016
    Posts:
    73
    If you generate Player project, the error would become visible in the IDE.
    upload_2022-6-1_12-46-40.png
     
  4. Kurt-Dekker

    Kurt-Dekker

    Joined:
    Mar 16, 2013
    Posts:
    38,745
    You have a mismatched compiler directive (#if UNITY_EDITOR / #endif) enclosing an irregular number of open / close braces.

    If you had posted the code formatted correctly, anyone here could see it and tell you the exact line of the mistake.

    If you post a code snippet, ALWAYS USE CODE TAGS:

    How to use code tags: https://forum.unity.com/threads/using-code-tags-properly.143875/

    You may edit your post above.

    Welcome! Time to step up your typing accuracy!

    Tutorials and example code are great, but keep this in mind to maximize your success and minimize your frustration:

    How to do tutorials properly, two (2) simple steps to success:

    Step 1. Follow the tutorial and do every single step of the tutorial 100% precisely the way it is shown. Even the slightest deviation (even a single character!) generally ends in disaster. That's how software engineering works. Every step must be taken, every single letter must be spelled, capitalized, punctuated and spaced (or not spaced) properly, literally NOTHING can be omitted or skipped.

    Fortunately this is the easiest part to get right: Be a robot. Don't make any mistakes.
    BE PERFECT IN EVERYTHING YOU DO HERE!!


    If you get any errors, learn how to read the error code and fix your error. Google is your friend here. Do NOT continue until you fix your error. Your error will probably be somewhere near the parenthesis numbers (line and character position) in the file. It is almost CERTAINLY your typo causing the error, so look again and fix it.

    Step 2. Go back and work through every part of the tutorial again, and this time explain it to your doggie. See how I am doing that in my avatar picture? If you have no dog, explain it to your house plant. If you are unable to explain any part of it, STOP. DO NOT PROCEED. Now go learn how that part works. Read the documentation on the functions involved. Go back to the tutorial and try to figure out WHY they did that. This is the part that takes a LOT of time when you are new. It might take days or weeks to work through a single 5-minute tutorial. Stick with it. You will learn.

    Step 2 is the part everybody seems to miss. Without Step 2 you are simply a code-typing monkey and outside of the specific tutorial you did, you will be completely lost. If you want to learn, you MUST do Step 2.

    Of course, all this presupposes no errors in the tutorial. For certain tutorial makers (like Unity, Brackeys, Imphenzia, Sebastian Lague) this is usually the case. For some other less-well-known content creators, this is less true. Read the comments on the video: did anyone have issues like you did? If there's an error, you will NEVER be the first guy to find it.

    Beyond that, Step 3, 4, 5 and 6 become easy because you already understand!