Assertion failure when adding existing tag component via bulk AddComponent (Entities 0.1.0)

Calling

public void AddComponent(NativeArray<Entity> entities, ComponentType componentType)

to add a tag, when one or more of the entities already has that tag, causes the following error. One part of the code is ok with the duplicate and returns a null, but a subsequent part of the code doesn't like that null which causes a fail in the assertion here:

Code (CSharp):

1.         [Conditional("ENABLE_UNITY_COLLECTIONS_CHECKS")]
2.         public static void AssertAreLayoutCompatible(Archetype* a, Archetype* b)
3.         {
4.             Assert.IsTrue(AreLayoutCompatible(a,b));

Am I meant to be disabling unity collections checks or something when trying to add tags that already exist? Or is it expected that I manually check my entities in my array to remove those which already have the tag?Or is this a regression?

Full stack below. Ciao.

 

By the way, assert error also triggers when chunk already has that component on it. E.g. via EntityQuery.

Which sux, because you can't just fire and forget a component.

I guess this is by design? Because adding component still triggers hard sync point.
So the intention is to have less of them? But then again, it just means that tag components are invalid design.

 

What about this one in EntityManager (e.g. when component is set via EntityQuery from different systems):

Code (CSharp):

1. [Conditional("ENABLE_UNITY_COLLECTIONS_CHECKS")]
2.         public void AssertCanAddComponent(NativeArray<ArchetypeChunk> chunkArray, ComponentType componentType)
3.         {
4.             var chunks = (ArchetypeChunk*) chunkArray.GetUnsafeReadOnlyPtr();
5.             for (int i = 0; i < chunkArray.Length; ++i)
6.             {
7.                 var chunk = chunks[i].m_Chunk;
8.                 if (ChunkDataUtility.GetIndexInTypeArray(chunk->Archetype, componentType.TypeIndex) != -1)
9.                     throw new ArgumentException(
10.                         $"A component with type:{componentType} has already been added to the chunk."); // <--- THIS ONE
11.                 ...
12.             }
13.         }

This one is by design and wont be removed, right?

Will there be a way to check if the chunk has a component attached to it efficiently?

 

Sure thing. Submitted bug report with case number 1173373.
Now comes the part when I hope I haven't made some stupid user error haha. Fairly confident I haven't, but we'll see .

 

Great, sounds like something I can improve on my end too! Cheers.