Resolved (Arguments.Add) "Dynamic String" example in Documentation doesn't work

I'm trying to update a Smart String following the example "Dynamic Strings" in the docs:
https://docs.unity3d.com/Packages/com.unity.localization@0.6/manual/Scripting.html

(I'm working with Unity 2019.3.14f1)
Visual Studio gives me an error in the line 18: HitsText.Arguments.Add(this); (Check screenshot)


I attached another screenshot too, showing the Unity GameObject Inspector to add more info.


I'm doing exactly the same like in the docs example.
Are the docs obsolete?

Thanks.

 

Thanks!
The code error got fixed with the code you shared, but my Smart String is still not updating.
Can you help me, please?

 

In the second screenshot you can see the Inpector of the TextMeshProText element where I'm setting the text.
The Localize String component sets the text "Hits{Hits}x" in the TextMeshProText element.

The following code does this: In the file HitsLocalization.cs I retrieve the value of PlayerPrefs.GetInt("Hits") and set it to the public variable int Hits:

Code (CSharp):

1.  
2. // File HitsLocalization.cs
3.  
4. public string Hits;
5. void Start()
6. {
7.     // PlayerPrefs contains the value 100
8.     Hits = PlayerPrefs.GetInt("Hits");
9. }
10.  

Then I drag the file HitsLocalization.cs into the Element 0 in the Format Arguments of the component Localize String (screenshot 2).

The problem is the following:

The text shown when loading the game is: "Hits 0x", but if I change the language of the game through the dropdown in the top right of the Game view, the text updates correctly to: "Hits 100x".
That means the Start() executed after the component Localize String and the value of Hits didn't get updated.
I tried Awake() and it didn't worked too.

 

Hi, I tried the code you suggested and Visual Studio throws an error about the class LocalizeStringEvent doesn't exists, I checked and using UnityEngine.Localization; is in the file.

 

Nevermind, I found the error, it was LocalizeStringBehaviour instead LocalizeStringEvent class.

Thank you so much for the help, the localization tool is amazing, you are doing a great work
Having one example about using LocalizeStringBehaviour in the docs should be really useful too.

Thanks again.

 

I'm trying to use this method, and it does work in editor.
However, for some reason, smart values are always blank and do not correctly get updated when I am building for android.

I'm not seeing any exceptions. putting in break points, i can see my getters getting called, but the final string is stripped of any smart format objects.

Any ideas?

 

Seems that for some reason, the formatter is null. Here is the exception coming up on adb logcat:

Code (csharp):

1.  
2. 2020-05-26 15:30:15.345 19268-19302/co.arctop.gaming E/Unity: FormattingException: Error parsing format string: Value cannot be null.
3.     Parameter name: source at 266
4.     You will be presented with a series of exercises (like: 100 +21 = )
5.    
6.     Write the correct answer and press the ‘Done’ button as quickly as possible.
7.    
8.     The calculations should be done only in your head, and without using a paper or calculator.
9.    
10.     You will have {SessionTime} {SessionMeasureUnits} to complete this task.
11.    
12.     Have fun!
13.     --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------^
14.       at UnityEngine.Localization.SmartFormat.SmartFormatter.FormatError (UnityEngine.Localization.SmartFormat.Core.Parsing.FormatItem errorItem, System.Exception innerException, System.Int32 startIndex, UnityEngine.Localization.SmartFormat.Core.Formatting.FormattingInfo formattingInfo) [0x00054] in E:\Dev\Gaming_Library_Native
15.  

Added an image of the stack trace as well.

Why would the formatter be null? the values of my properties are set, and it does work in editor. I have made sure to build the addressables. It is just the smart object that fails.

 

Using latest. Not sure which one it was. I will try and play around with the settings, but it is a holiday now here so not available to check until next Sunday. Will circle back with more info when I can.

 

So i've done some digging.

in SmartFormatter.cs , InvokeFormatterExtensions()

the formatter name property accessed in line 387: (see screenshot_1)

var formatterName = formattingInfo.Placeholder.FormatterName;
Is an empty string. The placeholder is valid, but no format or name is present here.
The stacktrace here is GetLocalizedString->FormatWithCache->Format->Format->EvaluateFormatters->InvokeFormatterExtension (see stacktrace.png).

Upon further playing around, it appears that removing the ListFormatter from the settings does result in correct working solution in build as well.

 

Hello,
I'm jumping into this thread as I have a related issue. How do you manage to put a variable of a script as an argument for a smart string like in your screenshot where it's written "Hits(HitsLocalization)" in Format arguments ?
I've carefully followed the manual and this thread, but I always end up with the error : "Could not evaluate the selector".

 

I'm also a bit lost with smart format... Here is what I have

I've added that script as a componenent in my label gameobject. It has finally worked with integers for another field, but here with the boolean, impossible to make it work.

Code (CSharp):

1. using TMPro;
2. using UnityEngine;
3. using UnityEngine.Localization;
4.  
5.     public class LocalizedFocus : MonoBehaviour
6.     {
7.         public LocalizedString myString;
8.  
9.         string localizedText;
10.  
11.         public bool focusMode = true;
12.  
13.         public TMP_Text focusLabel;
14.  
15.         /// <summary>
16.         /// Register a ChangeHandler. This will be called whenever we need to update our string.
17.         /// </summary>
18.         void OnEnable()
19.         {
20.             myString.Arguments = new[] { this };
21.             myString.RegisterChangeHandler(UpdateString);
22.         }
23.  
24.         private void OnDisable()
25.         {
26.             myString.ClearChangeHandler();
27.         }
28.  
29.         void UpdateString(string s)
30.         {
31.             localizedText = s;
32.         }
33.  
34.         void OnGUI()
35.         {
36.             // This will either call UpdateString immediately (if the table is loaded) or when the table is available.
37.             myString.RefreshString();
38.             focusLabel.text = localizedText;
39.            // GUILayout.Label(localizedText);
40.         }
41.     }
42.  
43.  

 

Thank you. I've tried both alternatives, they work well in the editor, but on ios devices, I get the same issue "Could not evaluate the selector". Do you have an idea from where it may come ?

 

@karl_jones Yeah, the list formatter is the issue, but since removing it works fine I'm happy to just do that until new version of the package are released.

I am having a different issue atm, that I'm trying to debug.
We use unity as a library within an android app. When I load in the player the first time, all smart objects are evaluated and presented correctly. After we quit the player, go back into our app's MainActivity, and re-launch unity, the values (of smart objects) are now empty again.
I'm in the process of trying to debug this, so I might have more info on the subject later. Wanted to point this out now, in case you might have other insight.
I'm guessing that this has to do with the localization system not getting destroyed/un-initialized, as the Unity player keeps some things around after it is unloaded in that context. So there is never another call to update the strings. Is there a way to force objects / system to re-load all the strings? or trigger all the "on changed" events?

 

Hi!
Didn't get it work. I take the Script from: https://docs.unity3d.com/Packages/com.unity.localization@0.7/manual/Scripting.html#dynamic-strings and attached it to a textfield. But the textfield doesn't show the time. What's missing?
Thanks.

 

Here comes the error code:

FormattingException: Error parsing format string: Could not evaluate the selector "TimeNow" at 17

The time now is {TimeNow}.

 

That's it. Thanks a lot.

 

I implemented it exactly as described here and it works, but after disabling once a parent of the localized string and when activating and calling RefreshString() the next time I receive following exception:

RefreshString should be used with StringChanged however no change handler has been registered.

UPDATE: I see know there is another thread for this: https://forum.unity.com/threads/eve...-lost-when-deactivating-a-game-object.959856/
I will try to figure out if the gameobject is really active when trying to refresh. Thanks for the great work into this package!

 

When being enabled yes, but I need to call it every frame to update because the variable to show in the smart string changed.

I posted my working code here in the other thread:
Event handlers on LocalizedStringEvent are lost when deactivating a game object

 

i do it this way, it works for me:

Code (CSharp):

1. LocalizeStringEvent lse = GetComponent<LocalizeStringEvent>();

change the string variable

Code (CSharp):

1. LocalizeStringlse.RefreshString();

and finally i have the refreshed string variable on my GUI.

 

Hi,
Everything worked for me until I clicked "Upgrade" over the Format Arguments of LocalizeStringEvent. Now instead of Format Arguments I see Local Variables.

In the attached screenshot in ShieldStringSmart I have "public int shieldCount = 0;", but when I run game I see "ShieldButtonText (ShieldStringSmart)) instead of 0.

Could you explain me what I'm doing wrong ?

Link to the screenshot:

https://imgur.com/a/510POBK