Search Unity

Good news ✨ We have more Unite Now videos available for you to watch on-demand! Come check them out and ask our experts any questions!
Dismiss Notice

Applying prefab with inactive children and TMP element breaks layout

Discussion in 'UGUI & TextMesh Pro' started by GilCat, Dec 12, 2017.

Page 1 of 2

GilCat

Joined:

Sep 21, 2013

Posts:

595
I'm facing a bug with UI + Text Mesh Pro where when i apply a prefab it will break layout settings only if i have UI gameobjects disabled.
Attached is a sample project and here are the reproduction steps:
1. Unzip the attached project
2. Open "Main" scene
3. Go to hierarchy "Canvas -> Panel" and disable child gameobject "Button"
4. Apply prefab
5. Activate back "Button" gameobject and see that it's text label is out of position

NOTE: This only happens if Canvas Scaler is set to *Constant Physical Size* and there is one Text Mesh Pro object in the prefab hierarchy
Use Unity 2017.3.0f2 and TMP from Asset Store

*Before applying steps*

*After applying steps*
Attached Files:
- TMP_Bug.zip
  
  File size:
  
  2.7 MB
  
  Views:
  
  116
GilCat, Dec 12, 2017

#1

MrEsquire likes this.
Foriero

Joined:

Jan 24, 2012

Posts:

480

This one seems related to what we have in Musicuso project.

Foriero, Dec 12, 2017

#2

GilCat likes this.
LeonhardP

Unity Technologies

Joined:

Jul 4, 2016

Posts:

2,086

Could you please also send this as a bug report via the bug reporter?

LeonhardP, Dec 12, 2017

#3
GilCat

Joined:

Sep 21, 2013

Posts:

595

I have submitted a bug via Unity Bug Reporter prior to this post. Got a reply from the team that does not solve my problem. (Case 977959)
Is that enough?

GilCat, Dec 12, 2017

#4

LeonhardP likes this.
GilCat

Joined:

Sep 21, 2013

Posts:

595

Reply from Unity QA was.
Please try setting the pivot point on the Button to be at the exact center (X 0.5, Y 0.5), this should make the button's label appear correctly.

That works on the actual example i've posted but we don't always want to have the pivot at that point and it doesn't clear the fact that there is something there to be fixed. I believe that they are looking into that

Thanks Unity QA for looking into this

GilCat, Dec 13, 2017

#5
BoaNeo

Joined:

Feb 21, 2013

Posts:

48

I have a similar problem but in my case the TMP object is not even related to the prefab (It appears as if a single random TMP instance gets moved to a completely random position). I've submitted a bug report, but I'm also rolling back to 2017.2 since this is the third destructive bug I've found since upgrading to 2017.3.

BoaNeo, Dec 22, 2017

#6

GilCat likes this.
GilCat

Joined:

Sep 21, 2013

Posts:

595

That also happens to me!
And this bug is still present in Unity2017.3.0f3

GilCat, Dec 22, 2017

#7
Stephan_B

Unity Technologies

Joined:

Feb 26, 2017

Posts:

4,525

GilCat said: ↑

That also happens to me!
And this bug is still present in Unity2017.3.0f3
Click to expand...

Just sharing that I had another user report a similar issue with the TMP Dropdown which appears to be related to object re-parenting. In this particular case, the Scrollbar is placed incorrectly after calling RectTransform.SetParent().

Last edited: Dec 22, 2017

Stephan_B, Dec 22, 2017

#8
Foriero

Joined:

Jan 24, 2012

Posts:

480

Yes some combination of scrollbar or scrollview with tmp is causing it. Please we need fix for this. M.

Foriero, Dec 23, 2017

#9
mcmorry

Joined:

Dec 2, 2012

Posts:

581

Also using an horizontal layout group, is causing some issues on the first element of the group. It keeps resetting the coordinates of the TMP transform after applying the changes to the prefab. (In this case I'm using the paid version of TMP)

mcmorry, Dec 23, 2017

#10
Stephan_B

Unity Technologies

Joined:

Feb 26, 2017

Posts:

4,525

Foriero said: ↑

Yes some combination of scrollbar or scrollview with tmp is causing it. Please we need fix for this. M.
Click to expand...

TMP is not causing the issue but instead exposing that something related to scene hierarchy and parenting of objects is not behaving correctly in 2017.3.

For instance, while trying to figure out why the Scrollbar of the TMP Dropdown is not in the correct position, I discovered that placing the Scrollbar object in the Template before the Viewport object works correctly. Looking more closely at this reveals that in one case the Anchored Position.x is -80 while in the other it is 0.

I will reach out to the appropriate folks at Unity about this once they are back from the Holidays.

mcmorry said: ↑

Also using an horizontal layout group, is causing some issues on the first element of the group. It keeps resetting the coordinates of the TMP transform after applying the changes to the prefab. (In this case I'm using the paid version of TMP)
Click to expand...

That could be different (not sure) so could you provide me with more details like a scene setup or repro project via PM or Unity bug report?

Stephan_B, Dec 23, 2017

#11

dadude123 likes this.
oneuglyrobot

Joined:

Jun 22, 2014

Posts:

9

Any short term solutions for this, spent all day repositioning objects that have broken.

Another issue is Prefabs have been wiping out any data links that are not within their hierarchy when updating (applying), this has been happening since 2017.1

Last edited: Dec 24, 2017

oneuglyrobot, Dec 24, 2017

#12
c0ffeeartc

Joined:

Jul 23, 2015

Posts:

31

Had this bug too. It changes position of UI elements inside scene even outside prefab, ui elements in my scene use anchored positioning.
In my case layout breaks with TextMeshProUGUI in hierarchy and enabled CanvasScaler in Canvas. So I disable CanvasScaler and enable it after all prefabs were applied and saved.

c0ffeeartc, Dec 25, 2017

#13

plipking likes this.
GilCat

Joined:

Sep 21, 2013

Posts:

595

In my example above you don't even need any drop-down or layout elements, just having that TMP text in the scene is enough. The particular case I've posted is definitely related to TMP since it doesn't happen if I use UI Text with the exact scene hierarchy.

GilCat, Dec 26, 2017

#14
Stephan_B

Unity Technologies

Joined:

Feb 26, 2017

Posts:

4,525

GilCat said: ↑

In my example above you don't even need any drop-down or layout elements, just having that TMP text in the scene is enough. The particular case I've posted is definitely related to TMP since it doesn't happen if I use UI Text with the exact scene hierarchy.
Click to expand...

I tested your example setup in Unity 5.5 thru 2017.3 using the current and previous version of TMP and this behavior can only be observed in Unity 2017.3. In all cases, the Anchored Position of the child object (either the Scrollbar or the Text) gets modified which results in this incorrect behavior.

This is definitely an issue that needs to be addressed. I see a few changes that were made in Unity 2017.3 that could be the source of this new behavior. I'll talk to the folks who made the changes once they are back from the Holidays.

Stephan_B, Dec 26, 2017

#15

GilCat likes this.
Foriero

Joined:

Jan 24, 2012

Posts:

480

And if possible please write internal test case.

Foriero, Dec 26, 2017

#16
c0ffeeartc

Joined:

Jul 23, 2015

Posts:

31

Stephan_B said: ↑

I tested your example setup in Unity 5.5 thru 2017.3 using the current and previous version of TMP and this behavior can only be observed in Unity 2017.3. In all cases, the Anchored Position of the child object (either the Scrollbar or the Text) gets modified which results in this incorrect behavior.

This is definitely an issue that needs to be addressed. I see a few changes that were made in Unity 2017.3 that could be the source of this new behavior. I'll talk to the folks who made the changes once they are back from the Holidays.
Click to expand...

Hello, another bug case with easy to reproduce project 979554 https://issuetracker.unity3d.com/is...ther-ui-elements-when-canvasscaler-is-enabled , its setup uses anchored positioning. Looking forward for patch, thanks.

Last edited: Dec 28, 2017

c0ffeeartc, Dec 27, 2017

#17
Erikoinen

Joined:

Nov 10, 2014

Posts:

67

Any way to get around this while waiting for an update?

Erikoinen, Dec 27, 2017

#18
Foriero

Joined:

Jan 24, 2012

Posts:

480

Yes. Not applying prefabs

Foriero, Dec 27, 2017

#19
Stephan_B

Unity Technologies

Joined:

Feb 26, 2017

Posts:

4,525

Erikoinen said: ↑

Any way to get around this while waiting for an update?
Click to expand...

The behavior also changes if the prefab is disabled in the scene. This is also affected by the CanvasScaler which depending on the change, you could disable before apply.

Stephan_B, Dec 27, 2017

#20
Jmangles

Joined:

Aug 1, 2015

Posts:

26

Had to revert to a backup from this, made a huuuuge mess of my menus. Even if I got them all back to where they should be, as soon as I saved the scene the sliders/dropdowns/TMProUGUI objects would move back to the incorrect position. Happened if I reverted any prefab in the scene as well since I was trying to do that to fix their anchored positions but as soon as I reverted one the rest would go all over the place again.

Jmangles, Dec 27, 2017

#21
Foriero

Joined:

Jan 24, 2012

Posts:

480

Stephan what if canvasscaler is part of the prefab itself how can i disable it???

Foriero, Dec 28, 2017

#22
Stephan_B

Unity Technologies

Joined:

Feb 26, 2017

Posts:

4,525

Foriero said: ↑

Stephan what if canvasscaler is part of the prefab itself how can i disable it???
Click to expand...

As it relates to prefabs, I am only getting the issue when using "Apply" on a prefab that is disabled. Using "Apply" on a prefab that is enabled appears to work as expected. If that is not the case for everyone, please Let me know and provide the steps to reproduce it.

Again, this is an issue that needs to be fixed. At this point, I am just trying to find some potential workaround until a proper fix is made available.

Stephan_B, Dec 28, 2017

#23
Foriero

Joined:

Jan 24, 2012

Posts:

480

Not only that. What I observe is that if we have parts of the prefab disabled. I mean some subobjects. Then we also get messed prefabs when trying Apply or Revert.

Foriero, Dec 28, 2017

#24
Erikoinen

Joined:

Nov 10, 2014

Posts:

67

It seems to screw up _mostly_ the ones that are disabled, but it does affect some enabled elements sometimes, too. The effect is the same for an enabled objects, but it seems to do it only for a single object (the first one in hierarchy?). In my case it's always been a TMPro text object.

I have a UI canvas prefab object that is used in multiple scenes, and it has multiple popups and such that need to be disabled, so none of these workarounds are really of use for me. :|

Erikoinen, Dec 28, 2017

#25
Erikoinen

Joined:

Nov 10, 2014

Posts:

67

However, the same bug affects all RectTransform objects for me, not just TMPro ones.

Erikoinen, Dec 28, 2017

#26
Erikoinen

Joined:

Nov 10, 2014

Posts:

67

Another note: Once the bug happens after Apply, Revert doesn't bring back the working one, it remains broken.

Erikoinen, Dec 28, 2017

#27
GilCat

Joined:

Sep 21, 2013

Posts:

595

If you Apply then when your Revert your are always reverting to that broken prefab. Here having your stuff in a version control system is handy to avoid major frustrations

GilCat, Dec 28, 2017

#28
Stephan_B

Unity Technologies

Joined:

Feb 26, 2017

Posts:

4,525
I have managed to narrow this down to accessing any property or function of any RectTransform when the Canvas Hierarchy is being modified / in flux which happens during object instantiation or when using "Apply" or "Revert" on a prefab contained in this hierarchy.

As it turns out, TextMesh Pro uses the OnRectTransformDimensionsChange() callback to know when the RectTransform size has changed and thus accesses the properties of its RectTransform which in these cases happens when the Canvas hierarchy is being modified and thus results in these reported issues.

Adding the following script to some new child GameObject of a Canvas which also contains a Prefab and a CanvasScaler will reproduce the behavior when using "Apply" on the prefab.

Code (csharp):

using UnityEngine;

using UnityEngine.UI;

public class UI_Object : Graphic

{

protected override void OnEnable()

{

Debug.Log("OnEnable()");

}

protected override void OnDisable()

{

Debug.Log("OnDisable()");

}

protected override void OnRectTransformDimensionsChange()

{

Debug.Log("OnRectTransformDimensionsChange() has been called.\nNew size is (" + rectTransform.sizeDelta);

}

}

Given this issue could affect anyone using these or similar callbacks in their own scripts / projects, we'll need to get a proper fix on this. Like I said before, I'll share my findings with the appropriate folks at Unity as soon as they are back from the holidays.

Hopefully, this can get fixed shortly, if not I already have a potential way to side step the issue in the case of TextMesh Pro. I'll provide feedback as soon as I have had a chance to discuss this internally.
Last edited: Dec 28, 2017

Stephan_B, Dec 28, 2017

#29

GilCat likes this.
Foriero

Joined:

Jan 24, 2012

Posts:

480

Thank you Stephen for narrowing it down. Does anyone know if the same bug occur when using nested prefabs from asset store?

Foriero, Dec 28, 2017

#30
Erikoinen

Joined:

Nov 10, 2014

Posts:

67

Thanks, Stephen. It is very severe indeed. I guess for now I just have to break the prefab links and avoid the automatic gesture of hitting Apply all the time.

Erikoinen, Dec 28, 2017

#31
Neo-Dragon

Joined:

Feb 29, 2016

Posts:

17

Erikoinen said: ↑

Thanks, Stephen. It is very severe indeed. I guess for now I just have to break the prefab links and avoid the automatic gesture of hitting Apply all the time.
Click to expand...

Don't do this ^

I have got a workaround.
It's a horrible workaround but I found it (the bug) was only affecting the first text object in the prefab.
Create a new textmeshpro object. Leave it all as the default except change the color to fully transparent (no color). It needs to be enabled.
Click apply on your prefab.
You'll have an invisible text object that will get screwed up instead.

Neo-Dragon, Jan 3, 2018

#32

reese015 and LeonhardP like this.
Robdon

Joined:

Jan 10, 2014

Posts:

133

Just fell into this bug after a few hours of looking into it, I found a few things.

I've posted it as a bug with a simple example project just incase it can help, case 984754

I've also noticed the same as Neo above, in that it only effects the first TextMeshPro object, so that is a work around.

Also for me, I had a Canvas Scaler on my Canvas, and it was set to 'Scale with Screen Size', which I had set to 4k (3840x2160). I've noticed that this only caused the above problem for me if the Game Window is set to anything other than the same. So if you make them the same, it doesn't cause it.

HTHs...

Robdon, Jan 4, 2018

#33
Andrew-Garrison

Joined:

Oct 3, 2012

Posts:

16
Stephan_B said: ↑

I have managed to narrow this down to accessing any property or function of any RectTransform when the Canvas Hierarchy is being modified / in flux which happens during object instantiation or when using "Apply" or "Revert" on a prefab contained in this hierarchy.

As it turns out, TextMesh Pro uses the OnRectTransformDimensionsChange() callback to know when the RectTransform size has changed and thus accesses the properties of its RectTransform which in these cases happens when the Canvas hierarchy is being modified and thus results in these reported issues.

Adding the following script to some new child GameObject of a Canvas which also contains a Prefab and a CanvasScaler will reproduce the behavior when using "Apply" on the prefab.

Code (csharp):

using UnityEngine;

using UnityEngine.UI;

public class UI_Object : Graphic

{

protected override void OnEnable()

{

Debug.Log("OnEnable()");

}

protected override void OnDisable()

{

Debug.Log("OnDisable()");

}

protected override void OnRectTransformDimensionsChange()

{

Debug.Log("OnRectTransformDimensionsChange() has been called.\nNew size is (" + rectTransform.sizeDelta);

}

}

View attachment 260232

Given this issue could affect anyone using these or similar callbacks in their own scripts / projects, we'll need to get a proper fix on this. Like I said before, I'll share my findings with the appropriate folks at Unity as soon as they are back from the holidays.

Hopefully, this can get fixed shortly, if not I already have a potential way to side step the issue in the case of TextMesh Pro. I'll provide feedback as soon as I have had a chance to discuss this internally.
Click to expand...

Stephan, Thanks for letting us know. Is there any further news on this? Should we just wait until 2018.1?
Andrew-Garrison, Jan 9, 2018

#34
Stephan_B

Unity Technologies

Joined:

Feb 26, 2017

Posts:

4,525

Andrew-Garrison said: ↑

Stephan, Thanks for letting us know. Is there any further news on this? Should we just wait until 2018.1?
Click to expand...

I just finished a conversation with @phil-Unity who just fixed the issue.

Expect to see a fix for this in the next or subsequent patch for Unity 2017.3.

Stephan_B, Jan 9, 2018

#35

GilCat likes this.
Andrew-Garrison

Joined:

Oct 3, 2012

Posts:

16

Stephan_B said: ↑

I just finished a conversation with @phil-Unity who just fixed the issue.

Expect to see a fix for this in the next or subsequent patch for Unity 2017.3.
Click to expand...

That's great news! Thank you!

Andrew-Garrison, Jan 10, 2018

#36
OTZ_20100

Joined:

Oct 17, 2016

Posts:

8

Fixed on today's patch? (Patch 2017.3.0p2 - 15 January 2018)

No fixes in patch notes match with that bug... :/

Someone tried ?

OTZ_20100, Jan 15, 2018

#37
Xtro

Joined:

Apr 17, 2013

Posts:

367

I am experiencing the same problem without using textmesh pro. I think it's a recttransform or layout related bug.

I tried 2017.3.0p2 and it's still broken.

Xtro, Jan 15, 2018

#38
Xtro

Joined:

Apr 17, 2013

Posts:

367

@phil-Unity Can you tell us the expected patch version which we can see this fix please?

Xtro, Jan 15, 2018

#39
Stephan_B

Unity Technologies

Joined:

Feb 26, 2017

Posts:

4,525

Xtro said: ↑

I am experiencing the same problem without using textmesh pro. I think it's a recttransform or layout related bug.

I tried 2017.3.0p2 and it's still broken.
Click to expand...

This is a RectTransform issue which affects UI components which includes the TextMeshProUGUI component.

Stephan_B, Jan 15, 2018

#40
OTZ_20100

Joined:

Oct 17, 2016

Posts:

8

I confirm too, 2017.3.0p2, and still here.

Hold on Unity Team, and please, inform us as soon as possible ! Thanks!

OTZ_20100, Jan 16, 2018

#41
GilCat

Joined:

Sep 21, 2013

Posts:

595

Also tried Unity 2018.1.0b2 with the same results.

GilCat, Jan 16, 2018

#42
Dizzy-Jump

Joined:

Oct 9, 2014

Posts:

11

have the same issue without TMP object. RectTransform on some UI object change randomly every time then i save any prefab but with TMP objects it much more annoying

Last edited: Jan 16, 2018

Dizzy-Jump, Jan 16, 2018

#43
tarmo-jussila

Joined:

Jun 4, 2015

Posts:

11

Is there any estimate when this will be patched?

tarmo-jussila, Jan 18, 2018

#44

Foriero likes this.
AdamWaters

Joined:

Aug 30, 2011

Posts:

94

I just wanted to drop in and say this issue is wildly frustrating. My RPG menus were a huge pain to reconstruct and right now we're limited to a single scene because I can't use a prefab.

I did discover a work around for anyone that wants to use it. Instead of setting the UI active/inactive, you can change the parent of a given UI to something that is not a Canvas. This seems to hold the position of all child elements. It does introduce a few other complications, but if you're against the wall it's something.

Any updates on the issue would be greatly appreciated.

AdamWaters, Jan 21, 2018

#45
bartofzo

Joined:

Mar 16, 2017

Posts:

83

Having the same issue, really frustrating. Any news?

bartofzo, Jan 21, 2018

#46
Xtro

Joined:

Apr 17, 2013

Posts:

367

OMG OMG OMG!!!! Are you kidding me UNTY TEAM?

*** Please notice that this is not a TextMeshPro bug. This is a general editor bug which TMP is being affected as all other editor features do. ***

I just installed 2017.3.0p3. (Patch 3) and it's still NOT fixed!!!

This bug was introduced in 2017.2 or one of it's patches. It's been MONTHS!!!! This is a critical engine feature we are talking about. This is not a minor bug. WHAT THE FUDGE!!! ????

Please just give us a version number which this will be FIXED in!!!!

It's said that @phil-Unity has fixed this bug but we still don't see it in patch 3 version.

Last edited: Jan 21, 2018

Xtro, Jan 21, 2018

#47

bartofzo, Dizzy-Jump and GilCat like this.
AntonVikharev

Joined:

Jan 17, 2017

Posts:

1

Might be helpful to fix it:

I found that the issue happens for the first TextMesh Pro UGUI in hierarchy when parent Canvas has enabled Canvas Scaler component set into "Scale With Screen Size" mode. If Canvas Scaler is disabled or in different scaling mode, then the problem does not happen. If TextMesh Pro UGUI component disabled, it happens anyway. If game object with TextMesh Pro UGUI component is disabled, then it skips it and applies the position change to the next one TextMesh Pro UGUI in hierarchy.

In the case if text go is a child of canvas and has center-middle anchors setup, then its local positions in RectTransform (Pos X, Pos Y) are set to 0 0 0.

Editor version is 2017.3.0p2

Last edited: Jan 23, 2018

AntonVikharev, Jan 23, 2018

#48

galactiform_joshua and GilCat like this.
GilCat

Joined:

Sep 21, 2013

Posts:

595

It is just sad that this bug keeps going version after version
It is tiresome...

GilCat, Jan 25, 2018

#49
Albarnie

Joined:

Oct 24, 2015

Posts:

12

At this point, the bug is starting to feel as if it is a normal limitation of unity 'No UI', rather than just a bug. that's how long it has been. just downloaded the new 2018.1.0b3 beta (0b4 download doesn't work) and the bug is still here. I cannot develop a game when one of the core engine features isn't working. Please fix this.

Albarnie, Jan 27, 2018

#50

(You must log in or sign up to reply here.)

Page 1 of 2