any simple way to check something in the list?

Hello all,
I'm new for scriupting so I have a question about how to simplify my script
So i have a list named Char1AttackCommand[ ], my intention is base on the list if it match to some key word then change the color :

Code (CSharp):

1.  void AssignCommandColor(int arrayNumber, string CharXAttackCommand)
2.     {
3.        if(IsCharacter1 == true)
4.         {
5.             if (BPM.Char1AttackCommand[1] == "Fire")
6.             {
7.                 UICommandReadyBar.color = Color.red;
8.             }else if (BPM.Char1AttackCommand[1] == "Water")
9.             {
10.                 UICommandReadyBar.color1 = Color.blue;
11.             }
12.             else if (BPM.Char1AttackCommand[1] == "Wind")
13.             {
14.                 UICommandReadyBar.color = Color.green;
15.             }
16.             else if (BPM.Char1AttackCommand[1] == "Dark")
17.             {
18.                 UICommandReadyBar.color = Color.black;
19.             }
20.             else if (BPM.Char1AttackCommand[1] == "Light")
21.             {
22.                 UICommandReadyBar.color = Color.yellow;
23.             }

Code (CSharp):

1.   if(IsCharacter2 ==true)
2.         {
3.             if (BPM.Char1AttackCommand[2] == "Fire")
4.             {
5.                 UICommandReadyBar.color = Color.red;
6.             }else if (BPM.Char1AttackCommand[2] == "Water")
7.             {
8.                 UICommandReadyBar.color1 = Color.blue;
9.             }
10.             else if (BPM.Char1AttackCommand[2] == "Wind")
11.             {
12.                 UICommandReadyBar.color = Color.green;
13.             }
14.             else if (BPM.Char1AttackCommand[2] == "Dark")
15.             {
16.                 UICommandReadyBar.color = Color.black;
17.             }
18.             else if (BPM.Char1AttackCommand[2] == "Light")
19.             {
20.                 UICommandReadyBar.color = Color.yellow;
21.             }

I need to do it for all the list, but i dont want to do it manually. may i know any way i can simplify it please
may thanks

 

you probably want to lookup the "switch" command.

Do you have a List, or an array? everything in your code suggests array, List being an actual thing https://msdn.microsoft.com/en-us/library/6sh2ey19(v=vs.110).aspx

 

Also, have a look at loops (especially for/foreach loops in your case) in combination with arrays or any type of collection and wrap your head around enumerations. Latter ones would replace your strings and guarantee that there's no typo and will be more efficient.

 

thanks for reply,
I have look at the for each loop, but dont really know how to make my logic work (sorry about the silly question.)

Code (CSharp):

1. foreach (string i in BPM.Char1AttackCommand)
2.             {
3.                  //Idont know what should i put it here
4.             }