Bug Advertisments Package 4.3.0 breaks Unity Cloud Build

I'm working on a cross-platform android/ios app for a paying client. I build my app on UCB. I have unit tests, so my UCB builds are configured to run tests. I don't want to release buggy software, so my UCB builds are configured to fail if unit tests fail.

All's well so far.

Recently, Google notified me that the old (3.x.x?) version of com.unity3d.ads:unity-ads collects sensitive data and that I would have to upgrade to 4.0.1.

So I naturally upgraded and wrangled with the changes to the API until it worked. When I submitted my working build to UCB via git, I got an error in UCB relating to the Advertisements package that didn't show up locally. This error causes my build to fail, even though none of my unit tests have actually failed.

I had a look, and this file exists in the package, not my code. It also exists in 4.3.0, not just 4.2.1. The above mentioned 'Placeholder.cs' file provided by Unity's package manager contains obsolete code, and thus breaks my builds.

It looks like a very simple fix, simply changing line 83 from

Code (CSharp):

1. if (m_CurrentScreenOrientation == ScreenOrientation.Landscape)

to something like

Code (CSharp):

1. if (m_CurrentScreenOrientation == ScreenOrientation.LandscapeLeft || m_CurrentScreenOrientation == ScreenOrientation.LandscapeRight)

But unfortunately, I don't think I can do anything about it. The class is inside a unity Package Manager package provided by Unity, and I don't think I can override it in any way, because if I change the contents of the file locally, the remote UCB will probably just download the package directly when building and ignore my changes.

Are there any other ways to fix this problem? My client is waiting for a new build.

 

Ideally, there would be a new version of Unity Advertisements on Package Manager soon that incorporates any changes needed for UCB, but that would require changes to the Package by whatever team is in charge of Unity Advertisements.

 

And I did verify that this file is in the package manager, not my code, by creating a new project, installing Unity Advertisments 4.3.0 and finding the bug on line 83 in that project as well.

 

I'm on Unity version 2021.2.0b16 (edbc0738c91b) if that's useful.

 

I found https://github.com/Unity-Technologies/unity-ads-android, but it doesn't seem to contain any code relevant to this bug, so I can't fork it and submit a PR.

 

I experimented with adding the change to my local version, but I was right, the package cache is not stored in a normal git repo for unity. Since the problem is never produced locally, this isn't useful for fixing the problem.

 

Here's the other thing, why is Placeholder.cs even being used on an android build? It's kept in the Editor folder of the plugin, causing me to believe that it's related to placeholder ads shown in the editor, not real ads shown on android.

 

This repo is clearly for the adroid/java ads implementation, not the unity C# one. I can't find the correct C# repo, I assume it's private.

 

I built a blank project and added Unity Ads to it in order to send the project and instructions to unity support as a bug.

 

Now, conveniently, I can't access Jira to view the bug report.

this has become a devlog.

 

How do you report a bug with the bug reporting system?

 

To clarify, I built a simple repro project and submitted the bug to Unity through the Editor. Some time later I got an email about my bug. It directs me to a Jira incident, IN-14807. When I try to log into Jira, it simply tells me that I'm not authorized to view this portal. No further information is given. My bug submission went into a black hole.

This has been extraordinarily frustrating. So far I have received ZERO support from Unity over a mission-critical bug that is definitely Unity's fault. Not even so much as a word.

I don't understand why I'm getting radio silence on this. Is the answer so obvious that it's not worth the time to type a single reply? Is it a Somebody Else's Problem? And if so, who? Wrong forum? Which?

And if the answer is simply: "Don't test on UCB," then that just seems like an insane idea for a production app.

 

Landscape is not deprecated in 2020 (only Unknown is) but maybe that's a 2021 thing? (I'm using 2020, not 2021)

If it is then yes, I would say that's a Unity bug. I'm surprised they haven't commented, as it's quite obvious if that's the case.

I wasn't aware that deprecations cause UCB to error (fail) though. They should be warnings (not fails) so maybe that's a configurable thing that you could change? (until Unity fix the issue)

 

I did apparently have UCB building on latest, so I'm checking to see if setting it specifically to my dev editor version remedies that.

As for the warning becoming an error, I don't see any configuration options for that. The only UCB config options for testing are

• Run my project’s unit tests when building
• Run PlayMode tests
• Run EditMode tests
• Mark build as failed if any test fails

I didn't realize that the editor version was what was determining the deprecations of the package manager content. I suppose that means that newer versions of Unity are incompatible with newer versions of the Advertisements package? Thus meaning that I should try moving forward on Unity 2020 + Advertisemens 4.30 => Google Play?

God, I hope there aren't any similar version requirements for iOS otherwise I'm definitely going to end up stuck.

 

And THANK YOU

 

I wouldn't say incompatible, rather it may show deprecation warnings. But this is the first time I've heard of a deprecation failing a build. It might be worth posting in the UCB about that.

I'm using 2020.LTS and all the latest UGS packages on both iOS & Android without any issues (built with UCB)

I'm holding off on 2021.LTS for now as I've seen numerous issues reported with it. Hopefully in 3-6 months it'll be more mature\stable.

Good luck anyway, hopefully that'll help you get back on track (even if it's only a workaround)

 

I've never seen an option called "fail my build if you detect any warnings" in UCB, but I'll wait until 4.4.0 to see if I can get this to work.

It looks to me like there's a relatively simple regex running on each line in the full log to see if it counts as an error on UCB, because it seems to highlight any call that has the word "error" in it, even it's not actually receiving an error. But I don't know how that whole system works.

 

I have the exact same problem as @arcandio. Even though this is just supposed to be a warning, it DOES fail our builds on Unity Cloud Build. You can read about it in my post here: https://forum.unity.com/threads/facebook-sdk-fails-due-to-cs0619-errors.1342538/#post-8480567

Do you know when version 4.4.0 of the Ads SDK is coming out?

Thank you very much in advance.

 

Thanks! Looking forward to it. Will test it as soon as it's available.

 

Still waiting on this :\

 

I'm using 4.4.1 here (together with Unity 2020.3 LTS), and it has been available to me for several weeks now. It's not "Verified" yet though.