Adventure Game Q&A

Hi @Adam-Buckner!

I'm working on this project right now. I went on the learn page and something is missing: nowhere are the names of the two guys on the video mentioned! I think the man on the right is a "James" and the one on the left is you but how can we thank them if we do not know who they are?

In fact, if I recall correctly, very few projects are attributed.

 

Thank you!

I wish the best to Adam.

 

Hi - downloaded Phase 5, but the InteractableEditor script is missing from the download bundle. Could you please post a copy of the script here. Many thanks

 

The script is in project phase 1 "Assets\Scripts\Editor\Interaction".

 

About setting the "Locomotion" tag to the states Idle and Walking:

• in the video, they enter the tag in each of them one after another but this can be done by multi-selecting the above mentioned animations in the state machine (avoiding possible misspelling).

​

 

I'm currently studying this project with Unity 2018.2.13f01. In the PlayerMovement script, the NavMeshAgent must be stopped and restarted; it appears that both

Code (CSharp):

1. NavMeshAgent.Stop ();
2. NavMeshAgent.Resume ();

are now deprecated.

Code (CSharp):

1. NavMeshAgent.IsStopped = true or false;

must be used instead.

New PlayerMovement script:

Code (CSharp):

1.     private void Stopping (out float speed)
2.     {
3.        agent.isStopped = true;           //instead of agent.Stop ();
4.  
5.        ...
6.  
7.     }
8.  
9.     private void Slowing (out float speed, float distanceToDestination)
10.     {
11.         agent.isStopped = true;           //instead of agent.Stop ();
12.  
13.         ...
14.  
15.     }
16.  
17. ...
18.  
19.     public void OnGroundClick (BaseEventData data)
20.     {
21.         ...
22.  
23.         agent.isStopped = false;            //instead of agent.Resume ():
24.  
25.      
26. public void OnInteractableClick (Interactable interactable)
27.    {
28.        ...
29.  
30.        agent.isStopped = false;            //instead of agent.Resume ():
31.     }

 

@James In fact, it is in all the projects, except the one in which we are supposed to work on it. The problem is that it is the full script that is in the other phases of the project, the places we are supposed to write are already written.

Here is the script as it should be in the phase 5 of the project:

 

Thanks. I thought the OnAnimatorMove was overriding but if I remove it it the character stops working. I moved the interaction location point and it did affect where the character collected the object so I think it's a combination of all 3. Now I just need to work out how to fix it all

Again thanks for your help

 

Update: It worked. I turned off the OnAnimatorMove and after some tinkering and help from my husband I turned the agent.isStopped to false instead of true in OnInteractableClick. However the character is not rotating to face the object when collecting but stays looking in the direction it was travelling in Back to research. Thanks again

 

Hello, I am stuck on Phase 2 which is the third video in the game. How exactly does the player move through the door in the security room and into the market? It appears to show no code or way that it was done in the video. Any help would greatly appreciated.

 

Hello @JamesB!

I have followed the tutorial (very well done by the way!) and wanted to extend on that, but I find myself with a problem I really can't get my head around, so I hope you can maybe help me.

My modifications were mostly on two parts. The first one was creating conditions that could hold a script (like the reactions) so I would be able to check on more complicated conditions. The second one was integrating the reaction collection in the condition collection. The idea was that I didn't want to have to look for the reaction on another object. I ended up with something looking like this.



However, on the reaction collection part of the editor I am unable to open the reaction foldout or change the reaction selected in the popup.

More specifically, after having done some debugging, I see that the values for the foldout bool (showReaction) or the popup selection int (selectedIndex) are set back to default just after I clicked. Debugging tells me that when I click, showReaction is equal to true but on the next OnInspectorGUI() it gets back to false.

On the other side, if I show the reaction collection directly (so not contained in a condition collection). it works perfectly. So I'm guessing it's the condition collection that isn't able to serialize the changes it created on the reaction collection.
I have been looking all over the internet for a beginning of hint, but I can't find anything.

I'm attaching the modified scripts I have.

Thank you in advance!

 

Hello @JamesB and happy holidays to you too!

Your answer pointed me in the right direction and I now have it working!

The issue was that the faulty editor was directly referenced as a ReactionCollectionEditor and not as a serialized property. I didn't notice but in the SubEditorSetup, the serialized properties of the subeditor are linked to the ones of the main editor.

Code (CSharp):

1.     private SerializedProperty reactionCollectionProperty;
2.     private ReactionCollectionEditor reactionEditor;
3.  
4. //Later in code
5.  
6.     reactionEditor.reactionsProperty = reactionCollectionProperty;

This is not the full code, but I'll attach the script if anyone else wants to check.

Thank you for your help!

 

@JamesB Thanks for a great tutorial, especially what can be done with editor scripts!

I'm trying to expand to allow other condition types than just true/false. I've not come very far yet, but my first thougt would be to inherit the Condition scriptable object, but it feels wrong somehow, since I don't want to create a whole bunch of SO assets for each variable in the game. Or is that perhaps a good idea, to make it easier to save the game state later?

I just find it easier to have them directly inside the same GameObject and not in the resources folder. This can maybe (probably?) be done with SO and editor scripts, so I can see the variables inside the editor, but I still find editor scripting hard

I made something similar without scriptable objects, and I have an object called "Interaction Variables" on each interactable GameObject, to store "local" variables like "timesClicked" and I want to use this as a condition to run different reactions.

Should I rewrite the Condition logic completely to allow for this, or could you suggest a way to do it?

Thanks again!

 

Hi @JamesB thanks for replying so quickly, I'm still new to SO's so sorry if I talk about them incorrectly.

I'm trying to expand on the Conditions, to create different kinds of conditions, for example:
- ItemCondition (Does an item exist in the inventory)
- StateCondition (GeneratorStarted or PanicButtonClickedTimes, pretty much like your conditions)
- PlayerCondition (Choose a property from the player class, like health, and compare it)

So basically Condition is the parent class, and the above are child classes, that set the "satisfied" based on different things. But I don't fully understand if I should be using scriptable objects, and/or if I just store them inside the ConditionCollection.

Things like ItemCondition and PlayerCondition just checks with the inventory, and doesn't seem to store any data, while StateCondition needs to look up against some global variable, which might be a SO or just a list of floats somewhere.

The "AllConditions" asset confused me a bit, since in the project view, it has all the conditions as children.

I love the modularity of this, but I'm trying to see the benefits of using ScriptableObjects.

Also I find the editor scripts amazing, but very complicated, and a lot of code, making it hard for me to customize. I'm using Odin Inspector which seem to be able to do things like inline editor, which might make this possible, without custom editors, but I'm not sure yet.

Thanks for the tip regarding garbage collector!

 

@JamesB Ah thanks for the explanation. I'm impressed that you still reply after all these years... but I guess that means it's still pretty solid!

I studied the editor scripts some more, and begin to understand them, and appreciated that you could use the default appearence of the scriptableobject, in those cases where you didn't need a custom editor.

You wouldn't know of a simple way of sorting the Reactions inside a ReactionCollection? It seems a bit more complex since we're having subeditors. But I'm thinking I need some drag/drop operation, and reorder the items of the
reactions array, and then redraw it.

I've seen some editors that use up/down arrows, I guess that's easier than drag drop.

I looked at https://bitbucket.org/rotorz/reorderable-list-editor-field-for-unity/src/master/ but I'm not sure if that's implementable with the subeditors. Here's what that looks like. I don't need to move between lists, just up/down within a list.

 

Thanks @JamesB, I also just found this, which seem to do exactly that, but allowing to select what type of scriptable object to add. He didn't publish the code for what he calls a ScriptableObjectDrawer.

I'll see what I can work out from that.

 

Saw some people in this thread mentioning having problems with making prefabs out of interactables (which is why I first came here).

I replaced the condition and reaction collections with UnityEvent in order to solve the issue. I'm guessing the polymorphism limitation mentioned here was the problem.

 

Hi @JamesB,
I've tried working through Phase 1 in Unity 2018.4 but cannot select OnGroundClick in the "Pointer Click" Event Trigger.
Trying the same thing in Unity 2017 works as expected.

If I remove the BaseEventData parameter from OnGroundClick it does show up, but of course then I can't get the PointerEventData.

Are BaseEventData parameters no longer available in Unity 2018 and if so how do I get to pointerCurrentRaycast or am I missing something else?

Btw. the Pointer Click header actually shows the BaseEventData parameter in 2017 but shows now parameter in 2018.
2017:

2018:


Thanks in advance

 

Hi @JamesB, thanks for the quick reply!

Unfortunately using PointerEventData doesn't seem to work either. So far I was unable to find anything in the Unity documentation or any tutorials for 2018+ that use the Event System in this way. I'm still quite new to Unity so I might just be using the wrong search terms. Any pointers on where I might find more information would be highly appreciated.

Btw. if anyone else is stuck at this and just wants to get on with it: As a workaround I removed the BaseEventData parameter and manually perform the raycast. (The Camera needs to be tagged as MainCamera in order for Camera.main to be set)

Code (CSharp):

1.  
2.     public void OnGroundClick()
3.     {
4.         if (!handleInput)
5.         {
6.             return;
7.         }
8.  
9.         Ray myRay = Camera.main.ScreenPointToRay(Input.mousePosition);
10.         RaycastHit raycastHit;
11.        
12.         if (!Physics.Raycast(myRay, out raycastHit, Mathf.Infinity, Physics.AllLayers))
13.         {
14.             return;
15.         }
16.  
17.         currentInteractable = null;
18.  
19.         NavMeshHit hit;
20.        
21.         if (NavMesh.SamplePosition(raycastHit.point, out hit, navMeshSampleDistance, NavMesh.AllAreas)) // now uses raycastHit.point instead of pointerData.pointerCurrentRaycast.worldPosition
22.         {
23.             destinationPosition = hit.position;
24.         }
25.         else
26.         {
27.             destinationPosition = raycastHit.point;
28.         }
29.  
30.         agent.SetDestination(destinationPosition);
31.         agent.Resume();
32.     }
33.  

 

@JamesB Thanks for your advice, I've created a bug report and already heard back. It's a known issue tracked here:
https://issuetracker.unity3d.com/is...e-callbackcontext-set-as-their-parameter-type
Have to say I'm really impressed with the quick response times and overall level of support!

 

I specify a individual delegate as suggested in EventTrigger.cs.
Now I can use PointerEventData :

Code (CSharp):

1. using UnityEngine;
2. using UnityEngine.EventSystems;
3.  
4.  
5. public class EventTriggerDelegateExample : MonoBehaviour
6. {
7.     void Start()
8.     {
9.         EventTrigger trigger = GetComponent<EventTrigger>();
10.         EventTrigger.Entry entry = new EventTrigger.Entry();
11.         entry.eventID = EventTriggerType.PointerDown;
12.         entry.callback.AddListener((data) => { OnPointerDownDelegate((PointerEventData)data); });
13.         trigger.triggers.Add(entry);
14.     }
15.  
16.     public void OnPointerDownDelegate(PointerEventData data)
17.     {
18.         Debug.Log("OnPointerDownDelegate called.");
19.     }
20. }

You still need to add the EventTrigger component for this to work,

 

Hello,
I encountered a problem with the ReactionCollection component as soon as you apply changes made to this component to the prefab.
For example when applying all overrides of the "CoinInteractable" gameobject to the prefab.
If you then add a new gameobject using that prefab all ReactionCollection components that were previously updated by applying are broken.

This is the error I get

NullReferenceException: Object reference not set to an instance of an object
ReactionCollectionEditor.SubEditorSetup (ReactionEditor editor) (at Assets/Scripts/Editor/Interaction/ReactionCollectionEditor.cs:60)
EditorWithSubEditors`2[TEditor,TTarget].CheckAndCreateSubEditors (TTarget[] subEditorTargets) (at Assets/Scripts/Editor/Abstracts/EditorWithSubEditors.cs:33)
ReactionCollectionEditor.OnEnable () (at Assets/Scripts/Editor/Interaction/ReactionCollectionEditor.cs:42)

When debugging the editor code it looks like the "editor" parameter is null. Usually it contains a subeditor. The subeditors are extracted and created from the "reactions" array of the ReactionCollection script. But in this case all the elements of the array are null. The array length is correct.

Any ideas how to fix this?

 

Is adventure game still working in unity. I imported it but I get 125 errors most of them Ui.
example :
Library\PackageCache\com.unity.package-manager-ui@2.0.3\Editor\Sources\UI\Common\Alert.cs(2,32): error CS0234: The type or namespace name 'UIElements' does not exist in the namespace 'UnityEngine.Experimental' (are you missing an assembly reference?)

 

I am using the newest version. I just downloaded it a few days ago and I am eager to learn. It was also a fresh project as the tutorial said to do. In reply to your suggestion of running it on on an older version...is it possible for me to run two different versions ? Or do I have to delete the new version first? I had also bought adventure creator and it uses that tutorial is the reason its so important. Thank you for your quick reply.

 

Thank you Jamesb. I am new to this so I'll look up that haunted jaunt and give it a go as well as the 2017 version of unity.Thank you for the very helpfully information I appreciate your reply.God bless.

 

I understand this question might be overly broad, but can anyone point me to a high level approach to saving the inventory items collected and saving the conditions that have been met. To be more specific saving them to a file that can be saved when the user exits the game. Is there a single high level object I could save aspects of to accomplish this, or several high level objects. What would my targets be for saving these two things.

 

James, your ability and willingness to respond to these issues so quickly is a testament to your value to Unity. It's not gone unnoticed looking through this thread. I suppose I forgot to add some context. I do have a decent grasp on serializing and deserializing the data types I'd need and being able to create and load a save file. I suppose I struggled with articulating my goals. I am looking for the very high level objects I might focus on saving to a file versus the approach of drilling down to saving many smaller components or values. Is there a "manager" or singleton of some type that holds most all relevant values I could save and load? Namely in this instance I'd like to save the inventory current status (items within in it), and save the global game conditions that have been met. Im less worried about saving position starting points or "levels".

 

That is an accurate recollection of the way the project is set up. All other scenes are loaded in additively to that persistent scene. I had no clue why this didn't occur to me that the persistent scene was the common denominator here. Sometimes these things can be right in front of your face and still not be apparent. Thank for your time assisting me with this.

 

There is a course on Udemy for a 2D Farming RPG that implements game save and load functionality using c# interfaces and binary serialisation .. might be of interest ... https://www.udemy.com/course/unity-...arming-rpg/?referralCode=C42F63591A88C6366FD3

 

I actually ended up putting together a writeup on two interesting design choices in the Adventure Game tutorial and ScriptableObjects. You can read it here if you're interested.

@JamesArndt also, there's a module on saving in the gamedev.tv RPG class. I have a few issues with it, so I wouldn't take it as gospel, but it definitely gives a good overview/second opinion.