Question Adding A Player Mid-Game | Netcode for Gameobjects

I've been struggling a lot lately with adding players to an existing server.

Here is the code snippets I'm using. When a new player spawns, it's as if the server has been the owner of that player from the start.

Code (CSharp):

1.  
2.  
3. [SerializeField] private GameObject playerPrefab;
4.  
5. private void Singleton_OnClientConnectedCallback(ulong obj) {
6.  
7.         SpawnPlayerServerRpc(playerPrefab, obj);
8.     }
9.  
10. [ServerRpc]
11.     private static void SpawnPlayerServerRpc(GameObject playerPrefab, ulong clientID, ServerRpcParams serverRpcParams = default) {
12.         GameObject playerTransform = Instantiate(playerPrefab);
13.         playerTransform.GetComponent<NetworkObject>().SpawnAsPlayerObject(serverRpcParams.Receive.SenderClientId, true);
14.     }
15.  

 

You need to pass that ulong client ID from OnClientConnectedCallback to SpawnAsPlayerObject. This is the ID of the client that has just connected.

What you're currently doing is passing the client ID from the caller of the RPC, which doesn't make any sense here.

But instead of making a ServerRPC, I would listen to the OnClientConnectedCallback on the server, and spawn the player object directly, like:

Code (CSharp):

1.     [SerializeField] private GameObject playerPrefab;
2.  
3.     private void Singleton_OnClientConnectedCallback(ulong newClientId) {
4.         if(!IsServer) return;
5.  
6.         GameObject playerTransform = Instantiate(playerPrefab);
7.         playerTransform.GetComponent<NetworkObject>().SpawnAsPlayerObject(newClientId, true);
8.     }