Search Unity

  1. Welcome to the Unity Forums! Please take the time to read our Code of Conduct to familiarize yourself with the forum rules and how to post constructively.
  2. We have updated the language to the Editor Terms based on feedback from our employees and community. Learn more.
    Dismiss Notice

Question a noob error i think :( i am new, maybe anyone can help me

Discussion in 'Scripting' started by SinnedK89, May 31, 2022.

  1. SinnedK89

    SinnedK89

    Joined:
    May 30, 2022
    Posts:
    5
    hi i am new here and maybe anyone can help me and tell me how work it correctly :3

    Code (CSharp):
    1. using System.Collections;
    2. using System.Collections.Generic;
    3. using UnityEngine;
    4.  
    5. public class TriggerBox1 : MonoBehaviour
    6. {
    7.     public GameObject triggerBox;
    8.     public GameObject triggerBox1;
    9.  
    10.  
    11.  
    12.     public void OnTriggerStay(Collider other)//<--- i want this void call in another script, is it possible?
    13.     {
    14.         //---------------------
    15.         if(other.gameObject.tag == "Player")
    16.         {    
    17.                 triggerBox1.SetActive(false);
    18.                 triggerBox.SetActive(false);
    19.          
    20.             if (Input.GetKey(KeyCode.E))
    21.             {
    22.                 triggerBox1.SetActive(true);
    23.                 triggerBox.SetActive(true);
    24.             }
    25.             else if (Input.GetKeyUp(KeyCode.E))
    26.             {
    27.                 triggerBox1.SetActive(true);
    28.                 triggerBox.SetActive(true);
    29.             }
    30.         }
    31.     }
    32.  
    33.         //---------------------
    34.         public void Testoloko()
    35.     {
    36.         triggerBox1.SetActive(true);
    37.         triggerBox.SetActive(true);
    38.     }
    39.  
    40.     //---------------------
    41.     private void OnTriggerExit(Collider other)
    42.     {
    43.         triggerBox1.SetActive(false);
    44.         triggerBox.SetActive(false);
    45.     }
    46.  
    47. }


    and here i have the problem to call this 1 void "triggerBox1.OnTriggerStay(Collider other);" :(


    Code (CSharp):
    1. using System.Collections;
    2. using System.Collections.Generic;
    3. using UnityEngine;
    4.  
    5. public class Testardo : MonoBehaviour
    6. {
    7.     TriggerBox1 triggerBox1;
    8.  
    9.     GameObject player;
    10.  
    11.  
    12.     // Start is called before the first frame update
    13.     void Awake()
    14.     {
    15.         //triggerBox1 = player.GetComponent<TriggerBox1>();
    16.         triggerBox1 = GetComponent<TriggerBox1>();
    17.     }
    18.  
    19.     //
    20.     void Update()
    21.     {
    22.         //WorkFine!
    23.         if (Input.GetKey(KeyCode.F))
    24.         {
    25.             triggerBox1.Testoloko();            
    26.         }
    27.      
    28.  
    29.         //didn't work! :(
    30.         if (Input.GetKey(KeyCode.E))
    31.         {
    32.             triggerBox1.OnTriggerStay(Collider other);  //<--- i do here anywhat wrong but i dont know what :( any idea what to do?    
    33.         }
    34.     }
    35.  
    36. }
    37.  
    Assets\Testardo.cs(32,48): error CS1003: Syntax error, ',' expected
     
    Last edited: May 31, 2022
  2. SinnedK89

    SinnedK89

    Joined:
    May 30, 2022
    Posts:
    5
    sorry i forgot to say what i want, i want call a void from another script
    but I don't know how to do this in this example

    "public void example(anywhat);" <--- between ();

    or does that not work?
     
  3. Johan_Liebert123

    Johan_Liebert123

    Joined:
    Apr 15, 2021
    Posts:
    474
    Please post your whole error message, to check what script and line it is on, it's simply saying your missing a ';' somewhere
     
  4. SinnedK89

    SinnedK89

    Joined:
    May 30, 2022
    Posts:
    5
    Assets\Testardo.cs(32,48): error CS1003: Syntax error, ',' expected
     
  5. SinnedK89

    SinnedK89

    Joined:
    May 30, 2022
    Posts:
    5
  6. Kurt-Dekker

    Kurt-Dekker

    Joined:
    Mar 16, 2013
    Posts:
    36,958
    You are just making typing errors. You can fix those yourself. Here is how:

    The complete error message contains everything you need to know to fix the error yourself.

    The important parts of the error message are:

    - the description of the error itself (google this; you are NEVER the first one!)
    - the file it occurred in (critical!)
    - the line number and character position (the two numbers in parentheses)
    - also possibly useful is the stack trace (all the lines of text in the lower console window)

    Always start with the FIRST error in the console window, as sometimes that error causes or compounds some or all of the subsequent errors. Often the error will be immediately prior to the indicated line, so make sure to check there as well.

    All of that information is in the actual error message and you must pay attention to it. Learn how to identify it instantly so you don't have to stop your progress and fiddle around with the forum.

    Remember: NOBODY here memorizes error codes. That's not a thing. The error code is absolutely the least useful part of the error. It serves no purpose at all. Forget the error code. Put it out of your mind.

    Tutorials and example code are great, but keep this in mind to maximize your success and minimize your frustration:

    How to do tutorials properly, two (2) simple steps to success:

    Step 1. Follow the tutorial and do every single step of the tutorial 100% precisely the way it is shown. Even the slightest deviation (even a single character!) generally ends in disaster. That's how software engineering works. Every step must be taken, every single letter must be spelled, capitalized, punctuated and spaced (or not spaced) properly, literally NOTHING can be omitted or skipped.

    Fortunately this is the easiest part to get right: Be a robot. Don't make any mistakes.
    BE PERFECT IN EVERYTHING YOU DO HERE!!


    If you get any errors, learn how to read the error code and fix your error. Google is your friend here. Do NOT continue until you fix your error. Your error will probably be somewhere near the parenthesis numbers (line and character position) in the file. It is almost CERTAINLY your typo causing the error, so look again and fix it.

    Step 2. Go back and work through every part of the tutorial again, and this time explain it to your doggie. See how I am doing that in my avatar picture? If you have no dog, explain it to your house plant. If you are unable to explain any part of it, STOP. DO NOT PROCEED. Now go learn how that part works. Read the documentation on the functions involved. Go back to the tutorial and try to figure out WHY they did that. This is the part that takes a LOT of time when you are new. It might take days or weeks to work through a single 5-minute tutorial. Stick with it. You will learn.

    Step 2 is the part everybody seems to miss. Without Step 2 you are simply a code-typing monkey and outside of the specific tutorial you did, you will be completely lost. If you want to learn, you MUST do Step 2.

    Of course, all this presupposes no errors in the tutorial. For certain tutorial makers (like Unity, Brackeys, Imphenzia, Sebastian Lague) this is usually the case. For some other less-well-known content creators, this is less true. Read the comments on the video: did anyone have issues like you did? If there's an error, you will NEVER be the first guy to find it.

    Beyond that, Step 3, 4, 5 and 6 become easy because you already understand!

    Finally, when you have errors... see the top of this post!
     
  7. Kurt-Dekker

    Kurt-Dekker

    Joined:
    Mar 16, 2013
    Posts:
    36,958
    Generally do not call Unity functions like this.

    Instead, make a function that both this script AND the other Unity function calls.
     
    SinnedK89 likes this.