Bug 0.10.0 cant pull from google sheets anymore

I upgrade to 0.10.0 and now I get this null reference everytime I try to pull a table

Code (CSharp):

1. NullReferenceException: Object reference not set to an instance of an object
2. UnityEditor.Localization.Plugins.Google.GoogleSheets.MergePull (System.Collections.Generic.List`1[T] columns, UnityEditor.Localization.StringTableCollection collection, System.Collections.Generic.IList`1[T] columnMapping, System.Boolean removeMissingEntries, UnityEditor.Localization.Reporting.ITaskReporter reporter) (at Library/PackageCache/com.unity.localization@0.10.0-preview/Editor/Plugins/Google/GoogleSheets.cs:593)
3. UnityEditor.Localization.Plugins.Google.GoogleSheets.PullIntoStringTableCollection (System.Int32 sheetId, UnityEditor.Localization.StringTableCollection collection, System.Collections.Generic.IList`1[T] columnMapping, System.Boolean removeMissingEntries, UnityEditor.Localization.Reporting.ITaskReporter reporter, System.Boolean createUndo) (at Library/PackageCache/com.unity.localization@0.10.0-preview/Editor/Plugins/Google/GoogleSheets.cs:478)
4. UnityEditor.Localization.Plugins.Google.GoogleSheetsExtensionPropertyDrawer.DrawSyncControls (UnityEditor.Localization.Plugins.Google.GoogleSheetsExtensionPropertyDrawerData data, UnityEditor.SerializedProperty property, UnityEngine.Rect& position) (at Library/PackageCache/com.unity.localization@0.10.0-preview/Editor/Plugins/Google/GoogleSheetsExtensionPropertyDrawer.cs:334)
5. UnityEditor.Localization.Plugins.Google.GoogleSheetsExtensionPropertyDrawer.OnGUI (UnityEditor.Localization.Plugins.Google.GoogleSheetsExtensionPropertyDrawerData data, UnityEngine.Rect position, UnityEditor.SerializedProperty property, UnityEngine.GUIContent label) (at Library/PackageCache/com.unity.localization@0.10.0-preview/Editor/Plugins/Google/GoogleSheetsExtensionPropertyDrawer.cs:197)
6. UnityEditor.Localization.UI.PropertyDrawerExtended`1[TData].OnGUI (UnityEngine.Rect position, UnityEditor.SerializedProperty property, UnityEngine.GUIContent label) (at Library/PackageCache/com.unity.localization@0.10.0-preview/Editor/UI/Utility/PropertyDrawerExtended.cs:33)
7. UnityEditor.PropertyDrawer.OnGUISafe (UnityEngine.Rect position, UnityEditor.SerializedProperty property, UnityEngine.GUIContent label) (at <e6e2fa0a47414cd2ac33237924761b45>:0)
8. UnityEditor.PropertyHandler.OnGUI (UnityEngine.Rect position, UnityEditor.SerializedProperty property, UnityEngine.GUIContent label, System.Boolean includeChildren, UnityEngine.Rect visibleArea) (at <e6e2fa0a47414cd2ac33237924761b45>:0)
9. UnityEditor.PropertyHandler.OnGUI (UnityEngine.Rect position, UnityEditor.SerializedProperty property, UnityEngine.GUIContent label, System.Boolean includeChildren) (at <e6e2fa0a47414cd2ac33237924761b45>:0)
10. UnityEditor.EditorGUI.PropertyFieldInternal (UnityEngine.Rect position, UnityEditor.SerializedProperty property, UnityEngine.GUIContent label, System.Boolean includeChildren) (at <e6e2fa0a47414cd2ac33237924761b45>:0)
11. UnityEditor.EditorGUI.PropertyField (UnityEngine.Rect position, UnityEditor.SerializedProperty property, UnityEngine.GUIContent label, System.Boolean includeChildren) (at <e6e2fa0a47414cd2ac33237924761b45>:0)
12. UnityEditor.Localization.UI.ReorderableListExtended.DrawElement (UnityEngine.Rect rect, System.Int32 idx, System.Boolean isActive, System.Boolean isFocused) (at Library/PackageCache/com.unity.localization@0.10.0-preview/Editor/UI/Utility/ReorderableListExtended.cs:81)
13. UnityEditorInternal.ReorderableList.DoListElements (UnityEngine.Rect listRect) (at <e6e2fa0a47414cd2ac33237924761b45>:0)
14. UnityEditorInternal.ReorderableList.DoLayoutList () (at <e6e2fa0a47414cd2ac33237924761b45>:0)
15. UnityEditor.Localization.UI.LocalizationTableCollectionEditor.OnInspectorGUI () (at Library/PackageCache/com.unity.localization@0.10.0-preview/Editor/UI/Tables/LocalizationTableCollectionEditor.cs:200)
16. UnityEditor.UIElements.InspectorElement+<>c__DisplayClass58_0.<CreateIMGUIInspectorFromEditor>b__0 () (at <e6e2fa0a47414cd2ac33237924761b45>:0)
17. UnityEngine.GUIUtility:ProcessEvent(Int32, IntPtr)
18.  

I do have data in the columns, was working fine before I updated unfortunately!

 

I experienced this bug too and rolled back to 0.9 to resolve it, colRowData was empty so colRowData[row] failed.

 

Same issue, do I need to file a bug report?

 

Unfortunately, can share neither source code nor google doc so I doubt it will be useful for you, but if you have a preview version or something equivalent I can test.

 

Added log into scripts


Debug.LogError($"{colRowData[row] == null}"); => false
Debug.LogError($"{colRowData[row]?.Values == null}"); => true

So yes, it happens on the first empty cell. We have a locale that does not include all values, it should go to the fallback

 

I get another error on cloud build, both ios and android builds after upgrading to 0.10.0 and dependencies


FileNotFoundException: Library/com.unity.addressables/aa/...

Testing builds on my laptop, android seems to work as espected, but not for ios, it's like I haven't built addressable... I need more investigation to give you more informations and I will send a bug report if needed.

No Locale could be selected:
No Locales were available. Did you build the Addressables?

(Bundles are there in both platforms on my local build, in Library folder and in built project - Data/Raw in xcode project)

 

Yes, the build was ok on the previous commit.

 

Found, it fails with Addressable 1.16.16 (updated from 1.16.15 to 1.16.16)

 

Tried that to no success, looking deeper the problem is columns[col].rowdata was null above that as well. Will look into filing a bug

 

Bug has been reported, Case 1311922

I don't think you can repro it immediately as I'd need to add an email to the OAuth for them, but perhaps you can use your own google sheets in that setting to get the same errors before that's necessary.

 

PM sent with a link to an xlsx

 

A team member had success with changing that line to the line below, performing a null check on colRowData first, and now can pull from google sheets but can't push - likely because we're only changing the MergePull method and not any of the push ones, but its enough to unblock the workflow and just work out of the sheet online.

Code (CSharp):

1. if (colRowData != null && colRowData.Count > row && colRowData[row]?.Values?.Count > valueIndex)

 

same bug in 0.11.1 version - when column contains blank (untranslated row) between translated we got this error:

NullReferenceException: Object reference not set to an instance of an object

UnityEditor.Localization.Plugins.Google.GoogleSheets.MergePull (System.Collections.Generic.List`1[T] columns, UnityEditor.Localization.StringTableCollection collection, System.Collections.Generic.IList`1[T] columnMapping, System.Boolean skipFirstRow, System.Boolean removeMissingEntries, UnityEditor.Localization.Reporting.ITaskReporter reporter) (at Library/PackageCache/com.unity.localization@0.11.1-preview/Editor/Plugins/Google/GoogleSheets.cs:593)

UnityEditor.Localization.Plugins.Google.GoogleSheets.PullIntoStringTableCollection (System.Int32 sheetId, UnityEditor.Localization.StringTableCollection collection, System.Collections.Generic.IList`1[T] columnMapping, System.Boolean removeMissingEntries, UnityEditor.Localization.Reporting.ITaskReporter reporter, System.Boolean createUndo) (at Library/PackageCache/com.unity.localization@0.11.1-preview/Editor/Plugins/Google/GoogleSheets.cs:478)

UnityEditor.Localization.Plugins.Google.GoogleSheetsExtensionPropertyDrawer.DrawSyncControls (UnityEditor.Localization.Plugins.Google.GoogleSheetsExtensionPropertyDrawerData data, UnityEditor.SerializedProperty property, UnityEngine.Rect& position) (at Library/PackageCache/com.unity.localization@0.11.1-preview/Editor/Plugins/Google/GoogleSheetsExtensionPropertyDrawer.cs:334)

UnityEditor.Localization.Plugins.Google.GoogleSheetsExtensionPropertyDrawer.OnGUI (UnityEditor.Localization.Plugins.Google.GoogleSheetsExtensionPropertyDrawerData data, UnityEngine.Rect position, UnityEditor.SerializedProperty property, UnityEngine.GUIContent label) (at Library/PackageCache/com.unity.localization@0.11.1-preview/Editor/Plugins/Google/GoogleSheetsExtensionPropertyDrawer.cs:197)

UnityEditor.Localization.UI.PropertyDrawerExtended`1[TData].OnGUI (UnityEngine.Rect position, UnityEditor.SerializedProperty property, UnityEngine.GUIContent label) (at Library/PackageCache/com.unity.localization@0.11.1-preview/Editor/UI/Utility/PropertyDrawerExtended.cs:33)

UnityEditor.PropertyDrawer.OnGUISafe (UnityEngine.Rect position, UnityEditor.SerializedProperty property, UnityEngine.GUIContent label) (at <1798d6bccd2b44b2854be2fbcc2463b3>:0)

UnityEditor.PropertyHandler.OnGUI (UnityEngine.Rect position, UnityEditor.SerializedProperty property, UnityEngine.GUIContent label, System.Boolean includeChildren, UnityEngine.Rect visibleArea) (at <1798d6bccd2b44b2854be2fbcc2463b3>:0)

UnityEditor.PropertyHandler.OnGUI (UnityEngine.Rect position, UnityEditor.SerializedProperty property, UnityEngine.GUIContent label, System.Boolean includeChildren) (at <1798d6bccd2b44b2854be2fbcc2463b3>:0)

UnityEditor.EditorGUI.PropertyFieldInternal (UnityEngine.Rect position, UnityEditor.SerializedProperty property, UnityEngine.GUIContent label, System.Boolean includeChildren) (at <1798d6bccd2b44b2854be2fbcc2463b3>:0)

UnityEditor.EditorGUI.PropertyField (UnityEngine.Rect position, UnityEditor.SerializedProperty property, UnityEngine.GUIContent label, System.Boolean includeChildren) (at <1798d6bccd2b44b2854be2fbcc2463b3>:0)

UnityEditor.Localization.UI.ReorderableListExtended.DrawElement (UnityEngine.Rect rect, System.Int32 idx, System.Boolean isActive, System.Boolean isFocused) (at Library/PackageCache/com.unity.localization@0.11.1-preview/Editor/UI/Utility/ReorderableListExtended.cs:81)

UnityEditorInternal.ReorderableList.DoListElements (UnityEngine.Rect listRect, UnityEngine.Rect visibleRect) (at <1798d6bccd2b44b2854be2fbcc2463b3>:0)

UnityEditorInternal.ReorderableList.DoLayoutList () (at <1798d6bccd2b44b2854be2fbcc2463b3>:0)

UnityEditor.Localization.UI.LocalizationTableCollectionEditor.OnInspectorGUI () (at Library/PackageCache/com.unity.localization@0.11.1-preview/Editor/UI/Tables/LocalizationTableCollectionEditor.cs:203)

UnityEditor.UIElements.InspectorElement+<>c__DisplayClass59_0.<CreateIMGUIInspectorFromEditor>b__0 () (at <a122028f8c314654ad750c3d9eb1f725>:0)

UnityEngine.GUIUtility:ProcessEvent(Int32, IntPtr, Boolean&)

 

Is this fixed in the latest version?

 

The one that comes with this workaround.

 

Hi Karl,

I updated the localization package to version 1.0.0-pre.9.

I can pull the sheet from google fine, but pushing to sheet is not working. i'm getting this error:

Code (CSharp):

1. Push `TableName` to Google Sheets: Failed
2. Object reference not set to an instance of an object
3. Checking if sheet needs resizing: 0.52s
4. Generating column headers: 0s
5. Generating push data: 0s
6. Total time: 0.52s
7. UnityEngine.UnitySynchronizationContext:ExecuteTasks ()

Looking forward to your help.

 

I am also still experiencing this error on 0.11.1-preview, still a Null Reference on the same line (when Pulling)

In this case it's

colRowData[row]?.Values

that is null

Could work around it by replacing with the code below (another

?.

null-conditional access)

Code (CSharp):

1. if (colRowData != null && colRowData.Count > row && colRowData[row]?.Values?.Count > valueIndex)

But how do I make this change stick when the Unity Package Manager reverts the code?!

 

Done! Case number is 1336745

And thanks for the tip about moving the package. Now I can confirm that the patch I mentioned earlier does indeed fix this. (Adding a single "?" to line 593)


EDIT: 1.0.0-pre.9 fixed this for me